Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cephfs_mirror: fix crash in update_fs_mirrors() #56148

Merged
merged 1 commit into from
May 13, 2024

Commits on Mar 19, 2024

  1. cephfs_mirror: check m_instance_watcher and m_mirror_watcher before u…

    …sing them
    
    Fixes the crash:
    ```
    std::scoped_lock<std::mutex>::scoped_lock (__m=..., this=<optimized out>, this=<optimized out>, __m=...) at /usr/include/c++/11/mutex:655
    cephfs::mirror::MirrorWatcher::is_failed (this=0x0) at /usr/src/debug/ceph-19.0.0-1578.g3d482f42.el9.x86_64/src/tools/cephfs_mirror/MirrorWatcher.h:56
    cephfs::mirror::FSMirror::is_failed (this=0x557478284340) at /usr/src/debug/ceph-19.0.0-1578.g3d482f42.el9.x86_64/src/tools/cephfs_mirror/FSMirror.h:52
    cephfs::mirror::Mirror::update_fs_mirrors (this=0x5574773c3e60) at /usr/src/debug/ceph-19.0.0-1578.g3d482f42.el9.x86_64/src/tools/cephfs_mirror/Mirror.cc:515
    
    ```
    
    Fixes: https://tracker.ceph.com/issues/64751
    Signed-off-by: Jos Collin <jcollin@redhat.com>
    joscollin committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    5b8b9c2 View commit details
    Browse the repository at this point in the history