New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: os/FileJournal: Fix journal write fail, align for direct io #5619

Merged
1 commit merged into from Oct 20, 2015

Conversation

Projects
None yet
4 participants
@liewegas
Member

liewegas commented Aug 20, 2015

os/FileJournal: Fix journal write fail, align for direct io
when config journal_zero_on_create true, osd mkfs will fail when zeroing journal.
journal open with O_DIRECT, buf should align with blocksize.

Backport: giant, firefly, dumpling
Signed-off-by: Xie Rui <875016668@qq.com>
Reviewed-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 80473f6)
@ghost

This comment has been minimized.

ghost commented Aug 29, 2015

What is the corresponding issue ? There does not seem to be a matching pull request for the cherry picked commit.

@ghost ghost self-assigned this Aug 29, 2015

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Sep 4, 2015

@ghost

This comment has been minimized.

ghost commented Sep 4, 2015

@smithfarm reading the comment helps... sorry for the noise ;-)

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Sep 4, 2015

@dachary Actually, I created the issue and added it to the comment :-)

@dmick

This comment has been minimized.

Member

dmick commented Oct 9, 2015

@dachary, is this ready to go?

@ghost

This comment has been minimized.

ghost commented Oct 9, 2015

@dmick @smithfarm knows how much testing it saw.

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Oct 12, 2015

@dmick I would not say it is ready yet. It was in the last round of firefly integration tests. The rados suite results are here: http://tracker.ceph.com/issues/11644#note-102

I am scheduling suites for a new round, now.

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Oct 12, 2015

ghost pushed a commit that referenced this pull request Oct 20, 2015

Merge pull request #5619: os/FileJournal: Fix journal write fail, ali…
…gn for direct io

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Oct 20, 2015

Loic Dachary
Merge pull request #5619 from liewegas/wip-journal-firefly
os/FileJournal: Fix journal write fail, align for direct io

Reviewed-by: Loic Dachary <ldachary@redhat.com>
Reviewed-by: Nathan Cutler <ncutler@suse.cz>

@ghost ghost merged commit 1f0f4bb into ceph:firefly Oct 20, 2015

@ghost ghost changed the title from os/FileJournal: Fix journal write fail, align for direct io to osd: os/FileJournal: Fix journal write fail, align for direct io Oct 24, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment