mgr/dashboard: securely store remote cluster token #56237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nizamial09
requested review from
ivoalmeida and
aaSharma14
and removed request for
a team
nizamial09
force-pushed
the
store-token-in-cookie
branch
from
4aac1a0
to
5bc2a63
Compare
cloudbehl
reviewed
Mar 18, 2024
...ontend/src/app/ceph/cluster/multi-cluster/multi-cluster-list/multi-cluster-list.component.ts
Outdated
Show resolved
Hide resolved
Instead of using the localStorage use cookies for storing the token more securely Fixes: https://tracker.ceph.com/issues/64958 Signed-off-by: Nizamudeen A <nia@redhat.com>
nizamial09
force-pushed
the
store-token-in-cookie
branch
from
5bc2a63
to
35a3e6d
Compare
ivoalmeida
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
I don't think I ever seen local storage used as a way of state management, let alone cookies. At some point I would like to introduce proper state management to the application, which also has the option of persisting data in the client.
That being said, I have nothing against this implementation, hence approving
I agree. A proper state management is needed. |
|
jenkins test dashboard cephadm |
cloudbehl
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using the localStorage use cookies for storing the token more
securely
Fixes: https://tracker.ceph.com/issues/64958
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e