Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reef: mgr/dashboard: rm warning/error threshold for cpu usage #56443

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

nizamial09
Copy link
Member

backport tracker: https://tracker.ceph.com/issues/65103


backport of #56295
parent tracker: https://tracker.ceph.com/issues/58838

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh

for multi-core cpu's the value can be more than 100% so it doesn't make
sense to show warning/error when the usage is at or more than 100%.
hence removing it

Fixes: https://tracker.ceph.com/issues/58838
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 131a707)
@nizamial09 nizamial09 requested a review from a team as a code owner March 25, 2024 05:38
@nizamial09 nizamial09 removed the request for review from a team March 25, 2024 05:38
@nizamial09 nizamial09 added this to the reef milestone Mar 25, 2024
@afreen23
Copy link
Contributor

Looks good! but I think your cherrypick is taken from your working branch, you can try rebasing then cherrypick, or check your remote references. Its not an issue, but just history would diverge I guess

@nizamial09
Copy link
Member Author

Looks good! but I think your cherrypick is taken from your working branch, you can try rebasing then cherrypick, or check your remote references. Its not an issue, but just history would diverge I guess

@afreen23: I cherry-picked using the backport script and it looks like it took the commit directly from ceph:main branch: https://github.com/ceph/ceph/pull/56295/commits, so it looks correct to me

@afreen23
Copy link
Contributor

Looks good! but I think your cherrypick is taken from your working branch, you can try rebasing then cherrypick, or check your remote references. Its not an issue, but just history would diverge I guess

@afreen23: I cherry-picked using the backport script and it looks like it took the commit directly from ceph:main branch: https://github.com/ceph/ceph/pull/56295/commits, so it looks correct to me

That was weird, for me its rhcs-dashboard@131a707

I think I see how it is:

Screencast.from.2024-03-25.14-59-39.webm

Copy link
Contributor

@afreen23 afreen23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving, looks like some reference issue in github itself.
Thanks!

@nizamial09
Copy link
Member Author

yeah, that looks weird...

@nizamial09 nizamial09 changed the title reef: mgr/dashboard: rm warning/error threshold for cpu usage reef: mgr/dashboard: rm warning/error threshold for cpu usage Mar 25, 2024
@nizamial09
Copy link
Member Author

jenkins test dashboard

@nizamial09 nizamial09 merged commit 78f31c6 into ceph:reef Mar 25, 2024
13 checks passed
@nizamial09 nizamial09 deleted the wip-65103-reef branch March 25, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
2 participants