Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement snapshot rename #5645

Merged
merged 8 commits into from Nov 5, 2015

Conversation

Projects
None yet
3 participants
@xinxinsh
Copy link
Member

xinxinsh commented Aug 24, 2015

No description provided.

@xinxinsh xinxinsh changed the title feature : implemented snapshot rename implement snapshot rename Aug 25, 2015

@dillaman

This comment has been minimized.

Copy link
Contributor

dillaman commented Aug 25, 2015

Can you also add the new feature to the librbd Python bindings?

@xinxinsh xinxinsh force-pushed the xinxinsh:wip-snap-rename branch from 2a4b840 to 58435d9 Aug 27, 2015

@xinxinsh

This comment has been minimized.

Copy link
Member Author

xinxinsh commented Aug 27, 2015

@dillaman , updated, pls help review

@xinxinsh xinxinsh force-pushed the xinxinsh:wip-snap-rename branch from 58435d9 to ce1712d Sep 1, 2015

xinxin shu
add snapshot rename methods in cls_rbd
Signed-off-by: xinxin shu <xinxin.shu@intel.com>

@xinxinsh xinxinsh force-pushed the xinxinsh:wip-snap-rename branch from ce1712d to 767fe92 Sep 1, 2015

@xinxinsh

This comment has been minimized.

Copy link
Member Author

xinxinsh commented Sep 1, 2015

@dillaman , updated, pls help review

xinxin shu added some commits Aug 20, 2015

xinxin shu
handle snap rename notify
Signed-off-by: xinxin shu <xinxin.shu@intel.com>
xinxin shu
add snapshot rename CLI
Signed-off-by: xinxin shu <xinxin.shu@intel.com>
xinxin shu
add unit test for snap rename in imagewatcher
Signed-off-by: xinxin shu <xinxin.shu@intel.com>
xinxin shu
add snap rename unit test in test_librbd.cc
Signed-off-by: xinxin shu <xinxin.shu@intel.com>
xinxin shu
add snap rename test in cls_rbd
Signed-off-by: xinxin shu <xinxin.shu@intel.com>
xinxin shu
add snap rename in python wrapper
Signed-off-by: xinxin shu <xinxin.shu@intel.com>
xinxin shu
add test for python binding
Signed-off-by: xinxin shu <xinxin.shu@intel.com>

@xinxinsh xinxinsh force-pushed the xinxinsh:wip-snap-rename branch 2 times, most recently from f9143d2 to 14c400f Sep 3, 2015

@xinxinsh

This comment has been minimized.

Copy link
Member Author

xinxinsh commented Sep 3, 2015

@dillaman , thanks for review, updated

@dillaman

This comment has been minimized.

Copy link
Contributor

dillaman commented Sep 3, 2015

LGTM -- we need to wait for the master branch to open for new features before merging.

Note to self: need to update #5735 to support this new feature

@dillaman dillaman self-assigned this Nov 5, 2015

dillaman added a commit that referenced this pull request Nov 5, 2015

Merge pull request #5645 from xinxinsh/wip-snap-rename
implement snapshot rename

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

@dillaman dillaman merged commit 2c968db into ceph:master Nov 5, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.