implement snapshot rename #5645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinxinsh
changed the title
|
Can you also add the new feature to the librbd Python bindings? |
xinxinsh
force-pushed
the
wip-snap-rename
branch
from
2a4b840
to
58435d9
Compare
|
@dillaman ， updated, pls help review |
xinxinsh
force-pushed
the
wip-snap-rename
branch
from
58435d9
to
ce1712d
Compare
Signed-off-by: xinxin shu <xinxin.shu@intel.com>
xinxinsh
force-pushed
the
wip-snap-rename
branch
from
ce1712d
to
767fe92
Compare
|
@dillaman , updated, pls help review |
added 7 commits
September 3, 2015 07:52
Signed-off-by: xinxin shu <xinxin.shu@intel.com>
Signed-off-by: xinxin shu <xinxin.shu@intel.com>
Signed-off-by: xinxin shu <xinxin.shu@intel.com>
Signed-off-by: xinxin shu <xinxin.shu@intel.com>
Signed-off-by: xinxin shu <xinxin.shu@intel.com>
Signed-off-by: xinxin shu <xinxin.shu@intel.com>
Signed-off-by: xinxin shu <xinxin.shu@intel.com>
xinxinsh
force-pushed
the
wip-snap-rename
branch
2 times, most recently
from
f9143d2
to
14c400f
Compare
|
@dillaman , thanks for review, updated |
|
LGTM -- we need to wait for the master branch to open for new features before merging. Note to self: need to update #5735 to support this new feature |
dillaman
pushed a commit
that referenced
this pull request
Nov 5, 2015
implement snapshot rename Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.