squid: mgr/cephadm: add some NVMEof gateway fields to be configurable by cephadm #56497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phlogistonjohn
approved these changes
Mar 28, 2024
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
adk3798
force-pushed
the
wip-65124-squid
branch
from
19d375b
to
7d9bebf
Compare
|
jenkins test make check |
|
jenkins test api |
|
jenkins test make check |
|
Failures all fall under
Nothing to block merging |
|
jenkins test make check |
1 similar comment
|
jenkins test make check |
Fixes: https://tracker.ceph.com/issues/64821 Signed-off-by: Gil Bregman <gbregman@il.ibm.com> (cherry picked from commit 86a5927)
Fixes: https://tracker.ceph.com/issues/64821 Signed-off-by: Gil Bregman <gbregman@il.ibm.com> (cherry picked from commit a16ac81) Conflicts: src/pybind/mgr/cephadm/templates/services/nvmeof/ceph-nvmeof.conf.j2 src/pybind/mgr/cephadm/tests/test_services.py
…hadm Fixes https://tracker.ceph.com/issues/65259 Signed-off-by: Gil Bregman <gbregman@il.ibm.com> (cherry picked from commit aa4adf9)
Fixes https://tracker.ceph.com/issues/65259 Signed-off-by: Gil Bregman <gbregman@il.ibm.com> (cherry picked from commit 187baff)
Currently, the mon client work is not merged on main, but our default nvmeof container will attempt to make use of it by default, causing it to crash. This makes it configurable and defaults the behavior to false. That can be changed once the work is actually present in main. Signed-off-by: Adam King <adking@redhat.com> (cherry picked from commit 3276471)
Fixes https://tracker.ceph.com/issues/65566 Signed-off-by: Gil Bregman <gbregman@il.ibm.com> (cherry picked from commit c2aa1fc)
Fixes https://tracker.ceph.com/issues/65566 Signed-off-by: Gil Bregman <gbregman@il.ibm.com> (cherry picked from commit da2d088)
adk3798
force-pushed
the
wip-65124-squid
branch
from
7d9bebf
to
a8822f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/65124
backport of #56369
parent tracker: https://tracker.ceph.com/issues/64821
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh