mgr/dashboard:Use advanced fieldset for rbd image #56514

afreen23 · 2024-03-27T09:51:50Z

Fixes https://tracker.ceph.com/issues/65025

using cd-advanced-fieldset component for advanced section
the same component is used in bucket form
this will align advanced sections of forms in dashboard

Screencast.from.2024-03-27.15-11-30.webm

Checklist

Tracker (select at least one)
- References tracker ticket
- Very recent bug; references commit where it was introduced
- New feature (ticket optional)
- Doc update (no ticket needed)
- Code cleanup (no ticket needed)
Component impact
- Affects Dashboard, opened tracker ticket
- Affects Orchestrator, opened tracker ticket
- No impact that needs to be tracked
Documentation (select at least one)
- Updates relevant documentation
- No doc update is appropriate
Tests (select at least one)
- Includes unit test(s)
- Includes integration test(s)
- Includes bug reproducer
- No tests

Show available Jenkins commands

jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows
jenkins test rook e2e

cloudbehl · 2024-03-27T10:33:10Z

I would like to add features in advance section as well.

afreen23 · 2024-03-27T15:30:23Z

I would like to add features in advance section as well.

cc @nizamial09 @ceph/dashboard wdyt ?
if we agree to move, I would do in a separate PR to track it better.

Thanks!

cloudbehl

Approved based on comment to do the movement of features in advance section in different PR.

afreen23 · 2024-03-28T10:55:23Z

jenkins test make check

afreen23 · 2024-03-28T10:58:47Z

jenkins retest this please

afreen23 · 2024-03-28T10:59:46Z

Approved based on comment to do the movement of features in advance section in different PR.

Thanks @cloudbehl

nizamial09 · 2024-03-28T15:23:54Z

I would like to add features in advance section as well.

sounds good to me!

I would do in a separate PR to track it better.

yup, let's do it separately

nizamial09 · 2024-03-28T15:24:25Z

once the test failure is addressed, this is good to go

.............................
  ● RbdFormComponent › test image configuration component › is visible

    expect(received).toBe(expected) // Object.is equality

    Expected: true
    Received: false

      299 |         fixture.debugElement.query(By.css('cd-rbd-configuration-form')).nativeElement.parentElement
      300 |           .hidden
    > 301 |       ).toBe(true);
          |         ^
      302 |     });
      303 |   });
      304 |

      at src/app/ceph/block/rbd-form/rbd-form.component.spec.ts:301:9
      at _ZoneDelegate.Object.<anonymous>._ZoneDelegate.invoke (node_modules/zone.js/bundles/zone-testing-bundle.umd.js:409:30)
      at ProxyZoneSpec.Object.<anonymous>.ProxyZoneSpec.onInvoke (node_modules/zone.js/bundles/zone-testing-bundle.umd.js:3830:43)
      at _ZoneDelegate.Object.<anonymous>._ZoneDelegate.invoke (node_modules/zone.js/bundles/zone-testing-bundle.umd.js:408:56)
      at Zone.Object.<anonymous>.Zone.run (node_modules/zone.js/bundles/zone-testing-bundle.umd.js:169:47)
      at Object.wrappedFunc (node_modules/zone.js/bundles/zone-testing-bundle.umd.js:4330:34)

afreen23 · 2024-03-28T15:38:56Z

once the test failure is addressed, this is good to go

.............................
  ● RbdFormComponent › test image configuration component › is visible

    expect(received).toBe(expected) // Object.is equality

    Expected: true
    Received: false

      299 |         fixture.debugElement.query(By.css('cd-rbd-configuration-form')).nativeElement.parentElement
      300 |           .hidden
    > 301 |       ).toBe(true);
          |         ^
      302 |     });
      303 |   });
      304 |

      at src/app/ceph/block/rbd-form/rbd-form.component.spec.ts:301:9
      at _ZoneDelegate.Object.<anonymous>._ZoneDelegate.invoke (node_modules/zone.js/bundles/zone-testing-bundle.umd.js:409:30)
      at ProxyZoneSpec.Object.<anonymous>.ProxyZoneSpec.onInvoke (node_modules/zone.js/bundles/zone-testing-bundle.umd.js:3830:43)
      at _ZoneDelegate.Object.<anonymous>._ZoneDelegate.invoke (node_modules/zone.js/bundles/zone-testing-bundle.umd.js:408:56)
      at Zone.Object.<anonymous>.Zone.run (node_modules/zone.js/bundles/zone-testing-bundle.umd.js:169:47)
      at Object.wrappedFunc (node_modules/zone.js/bundles/zone-testing-bundle.umd.js:4330:34)

Yep ! I was fixing that! should be fine now!

afreen23 · 2024-03-28T15:45:18Z

@cloudbehl https://tracker.ceph.com/issues/65207

nizamial09

LGTM. Thanks

[lint:eslint  ] All files pass linting.
[lint:eslint  ] 

Try running 'npm run fix' to fix some linting errors. Some errors might need a manual fix.

> ceph-dashboard@0.0.0 i18n:extract
> ng extract-i18n --output-path src/locale --progress=false

nizamial09 · 2024-03-29T06:51:46Z

src/pybind/mgr/dashboard/frontend/src/app/ceph/block/rbd-form/rbd-form.component.spec.ts

@@ -293,12 +293,11 @@ describe('RbdFormComponent', () => {
  });

  describe('test image configuration component', () => {
-    it('is visible', () => {


can we toggle the Advanced accordion so that the component will be visible?

sure, let me do that!

Fixes https://tracker.ceph.com/issues/65025 - using cd-advanced-fieldset component for advanced section - this will align advanced sections of forms in dashboard - changed heading of sections of rbd-configuration to h5 to better represent it as a sub section. - added unit tests for rbd image config Signed-off-by: Afreen <afreen23.git@gmail.com>

afreen23 · 2024-04-02T17:22:38Z

jenkins test dashboard cephadm

afreen23 · 2024-04-02T17:22:48Z

jenkins test dashboard

afreen23 · 2024-04-02T17:23:01Z

jenkins test make check arm64

afreen23 · 2024-04-03T01:20:06Z

jenkins test dashboard

afreen23 · 2024-04-03T01:20:15Z

jenkins test make check arm64

afreen23 · 2024-04-03T11:16:47Z

ceph dashboard tests failing due to:

+ cd src/pybind/mgr/dashboard
+ timeout 7200 ./run-frontend-e2e-tests.sh

[STARTED] Task without title.
[FAILED] Xvfb exited with a non zero exit code.
[FAILED] 
[FAILED] There was a problem spawning Xvfb.
[FAILED] 
[FAILED] This is likely a problem with your system, permissions, or installation of Xvfb.
[FAILED] 
[FAILED] ----------
[FAILED] 
[FAILED] Error: _XSERVTransSocketUNIXCreateListener: ...SocketCreateListener() failed
[FAILED] _XSERVTransMakeAllCOTSServerListeners: server already running
[FAILED] (EE) 
[FAILED] Fatal server error:
[FAILED] (EE) Cannot establish any listening sockets - Make sure an X server isn't already running(EE)
[FAILED] 
[FAILED] ----------
[FAILED] 
[FAILED] Platform: linux-x64 (Ubuntu - 22.04)
[FAILED] Cypress Version: 12.17.4
Xvfb exited with a non zero exit code.

cephadm ones due to:

make check ones:

E            +  where False = <function <lambda> at 0xffff89ed5ea0>(('', '', 124))

tests/test_util_funcs.py:665: AssertionError

afreen23 · 2024-04-03T11:18:37Z

jenkins test dashboard cephadm

afreen23 · 2024-04-03T11:18:57Z

jenkins test dashboard

afreen23 · 2024-04-03T11:20:23Z

jenkins test make check arm64

afreen23 · 2024-04-03T17:15:55Z

jenkins test make check arm64

afreen23 · 2024-04-03T17:16:21Z

jenkins test dashboard cephadm

afreen23 · 2024-04-03T19:17:05Z

jenkins test make check arm64

afreen23 · 2024-04-03T19:49:36Z

jenkins test make check arm64

afreen23 requested a review from a team as a code owner March 27, 2024 09:51

afreen23 requested review from ivoalmeida and nizamial09 and removed request for a team March 27, 2024 09:51

github-actions bot added dashboard pybind labels Mar 27, 2024

afreen23 requested a review from cloudbehl March 27, 2024 15:30

cloudbehl approved these changes Mar 28, 2024

View reviewed changes

afreen23 force-pushed the wip-advanced-pools branch from e7c326e to 018e12d Compare March 28, 2024 15:37

nizamial09 reviewed Mar 29, 2024

View reviewed changes

afreen23 force-pushed the wip-advanced-pools branch from 018e12d to 650a588 Compare April 2, 2024 04:59

afreen23 force-pushed the wip-advanced-pools branch from 650a588 to 2555211 Compare April 2, 2024 10:00

afreen23 requested a review from nizamial09 April 3, 2024 07:40

nizamial09 merged commit cde67a7 into ceph:main Apr 4, 2024
11 of 13 checks passed

This was referenced Apr 4, 2024

squid: mgr/dashboard:Use advanced fieldset for rbd image #56708

Merged

reef: mgr/dashboard:Use advanced fieldset for rbd image #56710

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mgr/dashboard:Use advanced fieldset for rbd image #56514

mgr/dashboard:Use advanced fieldset for rbd image #56514

afreen23 commented Mar 27, 2024 •

edited

cloudbehl commented Mar 27, 2024

afreen23 commented Mar 27, 2024

cloudbehl left a comment

afreen23 commented Mar 28, 2024

afreen23 commented Mar 28, 2024

afreen23 commented Mar 28, 2024

nizamial09 commented Mar 28, 2024

nizamial09 commented Mar 28, 2024

afreen23 commented Mar 28, 2024

afreen23 commented Mar 28, 2024

nizamial09 left a comment

nizamial09 Mar 29, 2024

afreen23 Mar 29, 2024

afreen23 commented Apr 2, 2024

afreen23 commented Apr 2, 2024

afreen23 commented Apr 2, 2024

afreen23 commented Apr 3, 2024

afreen23 commented Apr 3, 2024

afreen23 commented Apr 3, 2024

afreen23 commented Apr 3, 2024

afreen23 commented Apr 3, 2024

afreen23 commented Apr 3, 2024

afreen23 commented Apr 3, 2024

afreen23 commented Apr 3, 2024

afreen23 commented Apr 3, 2024

afreen23 commented Apr 3, 2024

mgr/dashboard:Use advanced fieldset for rbd image #56514

mgr/dashboard:Use advanced fieldset for rbd image #56514

Conversation

afreen23 commented Mar 27, 2024 • edited

Checklist

cloudbehl commented Mar 27, 2024

afreen23 commented Mar 27, 2024

cloudbehl left a comment

Choose a reason for hiding this comment

afreen23 commented Mar 28, 2024

afreen23 commented Mar 28, 2024

afreen23 commented Mar 28, 2024

nizamial09 commented Mar 28, 2024

nizamial09 commented Mar 28, 2024

afreen23 commented Mar 28, 2024

afreen23 commented Mar 28, 2024

nizamial09 left a comment

Choose a reason for hiding this comment

nizamial09 Mar 29, 2024

Choose a reason for hiding this comment

afreen23 Mar 29, 2024

Choose a reason for hiding this comment

afreen23 commented Apr 2, 2024

afreen23 commented Apr 2, 2024

afreen23 commented Apr 2, 2024

afreen23 commented Apr 3, 2024

afreen23 commented Apr 3, 2024

afreen23 commented Apr 3, 2024

afreen23 commented Apr 3, 2024

afreen23 commented Apr 3, 2024

afreen23 commented Apr 3, 2024

afreen23 commented Apr 3, 2024

afreen23 commented Apr 3, 2024

afreen23 commented Apr 3, 2024

afreen23 commented Apr 3, 2024

afreen23 commented Mar 27, 2024 •

edited