New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mds: log at a lower level when stopping #56629
Conversation
jenkins test make check arm64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change is OK, but the commit message is confusing: I thought this would be mangling with the debug_mds
log level. Something like "log at a lower level when stopping" would be more appropriate IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor commit message change - otherwise LGTM.
Log at lower level at log level 5 while the mds is stopping to track down issues like mds becoming laggy while stopping. It was being logged at level 7 before. https://tracker.ceph.com/issues/65260 Signed-off-by: Kotresh HR <khiremat@redhat.com>
5ebb5e7
to
ae687d3
Compare
Done |
jenkins test make check arm64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Commit message can take minor improvement -
Log at a lower level when the MDS is going to stop so that issues like
MDS becoming laggy can be tracked down. Reduce the log level from 7 to 5.
If you could add a bit more context from BZ in ticket description and in commit message, it would be useful in future.
I'll pick this PR in testing as soon as last couple of PRs from current batch get merged. |
jenkins test make check arm64 |
I think this change is good to merge (I've been lenient on dout() related changes to speed up merges). @rishabh-d-dave If you are fine with it, I'll merge this (if its in your test branch, its probably fine)? |
Reducing the mds log level from 7 to 5 while the
mds is stopping to track down issues like mds
becoming laggy while stopping.
https://tracker.ceph.com/issues/65260
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
x
between the brackets:[x]
. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows
jenkins test rook e2e