qa: make teardown behavior consistent for kclient/fuse mounts #56669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
|
jenkins test make check arm64 |
1 similar comment
|
jenkins test make check arm64 |
mchangir
reviewed
Apr 12, 2024
| @@ -418,8 +418,6 @@ def teardown(self): | |||
| """ | |||
| super(FuseMount, self).teardown() | |||
|
|
|||
| self.umount() | |||
|
|
|||
| if self.fuse_daemon and not self.fuse_daemon.finished: | |||
| self.fuse_daemon.stdin.close() | |||
| try: | |||
There was a problem hiding this comment.
out of academic interest, shouldn't the base class teardown() happen after the derived class teardown() ?
There was a problem hiding this comment.
Yes. We live in a special circle of Python's Hell.
I didn't think it necessarily needed backport. There shouldn't be a significant functional change. |
|
This PR is under test in https://tracker.ceph.com/issues/65530. |
|
This PR is under test in https://tracker.ceph.com/issues/65562. |
joscollin
approved these changes
Apr 19, 2024
|
This PR is under test in https://tracker.ceph.com/issues/65596. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e