rbd: add --object-size option #5676
Conversation
|
@jdurgin Hi Josh, I have sent this patch for http://tracker.ceph.com/issues/12112. Thanks and Regards, |
|
|
||
| Specifies the object size expressed as a number of bits, such that | ||
| the object size is ``1 << order``. The default is 22 (4 MB). | ||
| Specifies the object size in B/K/M, The default is 4 MB. |
There was a problem hiding this comment.
Might be nice to note that the smallest object-size is 4K and that the size will be rounded up the nearest power of two.
vumrao
force-pushed
the
wip-vumrao-12112
branch
from
f73fb8d
to
05d6ed8
Compare
|
@dillaman Thanks a lot. std::round(std::log2(object_size)); I have also corrected man pages changes. Thanks for your help. Regards, |
Object size can be specified when creating an image with the --order option, as a number of bits in the size. This patch is adding new option --object-size. This new option will specify object size directly for example --object-size 2M. It would be easier to use. --order is still present for backwards compatibility. For simplicity, we are rounding up the object size to the nearest power of 2. Fixes ceph#12112 Signed-off-by: Vikhyat Umrao <vumrao@redhat.com>
vumrao
force-pushed
the
wip-vumrao-12112
branch
from
05d6ed8
to
3551a55
Compare
|
LGTM -- master branch is currently in feature freeze for Infernalis |
|
@dillaman Thanks for review. Sure you can merge it when freeze will be removed. |
|
I will rebase this PR on top of this PR - #5987, once it would be merged. |
|
rbd cli refactor is merged - can you rebase this? |
|
sounds good |
Object size can be specified when creating an image with the --order option,
as a number of bits in the size.
This patch is adding new option --object-size. This new option will specify
object size directly for example --object-size 2M.
It would be easier to use. --order is still present for backwards compatibility.
For simplicity, we are rounding up the object size to the nearest power of 2.
Fixes #12112
Signed-off-by: Vikhyat Umrao vumrao@redhat.com