rgw: set correct requestId and hostId on s3select error #56864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, these fields remained constant despite the possibility of populating them with appropriate values. Fixes: https://tracker.ceph.com/issues/65468 Signed-off-by: Seena Fallah <seenafallah@gmail.com>
|
@galsalomon66 could you please help with review |
galsalomon66
reviewed
May 2, 2024
| @@ -246,8 +245,9 @@ void aws_response_handler::send_error_response_rgw_formatter(const char* error_c | |||
| s->formatter->open_object_section("Error"); | |||
| s->formatter->dump_string("Code", error_code); | |||
| s->formatter->dump_string("Message", error_message); | |||
| s->formatter->dump_string("Resource", "#Resource#"); | |||
| s->formatter->dump_string("RequestId", resource_id); | |||
| if (!s->trans_id.empty()) | |||
galsalomon66
reviewed
May 2, 2024
| @@ -429,7 +429,7 @@ int RGWSelectObj_ObjStore_S3::run_s3select_on_csv(const char* query, const char* | |||
|
|
|||
| if (s3select_syntax.get_error_description().empty() == false) { | |||
| //error-flow (syntax-error) | |||
| m_aws_response_handler.send_error_response_rgw_formatter(s3select_syntax_error,s3select_syntax.get_error_description().c_str(),s3select_resource_id); | |||
| m_aws_response_handler.send_error_response_rgw_formatter(s3select_syntax_error,s3select_syntax.get_error_description().c_str()); | |||
There was a problem hiding this comment.
please review #56834
this part was changed.
your changes could easily applied to that PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, these fields remained constant despite the possibility of populating them with appropriate values.
Fixes: https://tracker.ceph.com/issues/65468