Commits on Apr 17, 2024

1. qa/vstart_runner: don't let command run after timeout …

   Parameter "timeout" is accepted by LocalRemote.run() but the method
   doesn't do anything about it besides accepting it. Thus, this parameter
   has no effect.
   
   In LocalRemote.run(), pass this parameter to LocalRemoteProcess.wait()
   and from this method pass it to subprocess.Popen.communicate(). Thus,
   command will be terminated by subprocess module at seconds specified by
   "timeout" parameter. IOW, "timeout" parameter will have an effect.
   
   Fixes: https://tracker.ceph.com/issues/65533
   Signed-off-by: Rishabh Dave <ridave@redhat.com>

   

   rishabh-d-dave committed Apr 17, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 8bc23e5
   • Browse repository at this point

   Copy the full SHA

   8bc23e5 View commit details

   Browse the repository at this point in the history

2. qa/vstart_runner: allow more time for vstart.sh to run …

   This issue was exposed by ceph API test failure. Link to this failure - https://jenkins.ceph.com/job/ceph-api/72373/
   
   Copying traceback below from here https://jenkins.ceph.com/job/ceph-api/72373/consoleFull#-2010121386c212b007-e891-4176-9ee7-2f60eca393b7 -
   
   2024-04-15 12:32:34,808.808 INFO:__main__:> ../src/vstart.sh -n
   --nolockdep
   Using guessed paths
   /home/jenkins-build/build/workspace/ceph-api/build/lib/
   ['/home/jenkins-build/build/workspace/ceph-api/qa',
   '/home/jenkins-build/build/workspace/ceph-api/build/lib/cython_modules/lib.3',
   '/home/jenkins-build/build/workspace/ceph-api/src/pybind']
   Traceback (most recent call last):
     File
   "/home/jenkins-build/build/workspace/ceph-api/build/../qa/tasks/vstart_runner.py",
   line 1552, in <module>
       exec_test()
     File
   "/home/jenkins-build/build/workspace/ceph-api/build/../qa/tasks/vstart_runner.py",
   line 1402, in exec_test
       remote.run(args=args, env=vstart_env, timeout=(3 * 60))
     File
   "/home/jenkins-build/build/workspace/ceph-api/build/../qa/tasks/vstart_runner.py",
   line 452, in run
       return self._do_run(**kwargs)
     File
   "/home/jenkins-build/build/workspace/ceph-api/build/../qa/tasks/vstart_runner.py",
   line 491, in _do_run
       proc.wait(timeout)
     File
   "/home/jenkins-build/build/workspace/ceph-api/build/../qa/tasks/vstart_runner.py",
   line 252, in wait
       out, err = self.subproc.communicate(timeout=timeout)
     File "/usr/lib/python3.10/subprocess.py", line 1152, in communicate
       stdout, stderr = self._communicate(input, endtime, timeout)
     File "/usr/lib/python3.10/subprocess.py", line 2004, in _communicate
       self._check_timeout(endtime, orig_timeout, stdout, stderr)
     File "/usr/lib/python3.10/subprocess.py", line 1196, in _check_timeout
       raise TimeoutExpired(
   subprocess.TimeoutExpired: Command '../src/vstart.sh -n --nolockdep'
   timed out after 180 seconds
   
   Signed-off-by: Rishabh Dave <ridave@redhat.com>

   

   rishabh-d-dave committed Apr 17, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 03b3329
   • Browse repository at this point

   Copy the full SHA

   03b3329 View commit details

   Browse the repository at this point in the history