mgr/cephadm: don't mark daemons created/removed in the last minute as stray #56957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adk3798
force-pushed
the
no-stray-recent-removal
branch
2 times, most recently
from
e663b1c
to
e7a9292
Compare
adk3798
commented
Apr 22, 2024
… stray There is sometimes a slight delay between when the core mgr knows a daemon has been created/removed and when cephadm knows it as been created/removed. This can cause stray daemon warnings to pop up for a few seconds at a time. This patch tries to avoid that by not marking daemons as stray that it knows it just created/removed in the past minute. Signed-off-by: Adam King <adking@redhat.com>
Was adding a line to serve.py that did if ((datetime_now() - t).total_seconds() < 60) and this was causing the remote_executables test to fail with ValueError: _names: unexpected type: <ast.BinOp object at 0x7f0985c8d670> where it seems the (datetime_now() - t) was resolving to an ast.BinOp node which had no case in _names. This patch makes it so the remote_executables test can also handle these BinOp nodes and the binary operations that could be within the node Signed-off-by: Adam King <adking@redhat.com>
adk3798
force-pushed
the
no-stray-recent-removal
branch
from
e7a9292
to
d28aabd
Compare
adk3798
changed the title
14 tasks
|
jenkins test make check |
|
Most failures were Besides that, failures were:
|
|
failures:
Overall, nothing unexpected in the run For this PR in particular, only stray daemon warnings from the run were related to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is sometimes a slight delay between when the core
mgr knows a daemon has been removed and when cephadm knows
it as been removed. This can cause stray daemon warnings
to pop up for a few seconds at a time. This patch tries
to avoid that by not marking daemons as stray that it
knows it just removed in the past minute.
This will be inherently tested by the check for any CEPHADM_STRAY_DAEMON
warnings that is already happening in the tests, which we know are currently
present (and has been confirmed to happen when removing nfs and osd daemons
on occasion)
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e