crimson/osd/pg: reset the snap mapper's backend when pg interval changes #57125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you please explain how this assert relates to the stale cache? |
athanatos
approved these changes
May 1, 2024
src/common/map_cacher.hpp
Outdated
| @@ -85,6 +85,12 @@ class MapCacher { | |||
| public: | |||
| MapCacher(StoreDriver<K, V> *driver) : driver(driver) {} | |||
|
|
|||
| #ifdef WITH_SEASTAR | |||
There was a problem hiding this comment.
This behavior is not specific to seastar, remove the ifdef.
src/common/sharedptr_registry.hpp
Outdated
| @@ -61,6 +61,13 @@ class SharedPtrRegistry { | |||
| waiting(0) | |||
| {} | |||
|
|
|||
| #ifdef WITH_SEASTAR | |||
There was a problem hiding this comment.
This behavior is not specific to seastar, remove the ifdef.
src/osd/SnapMapper.h
Outdated
| @@ -356,6 +356,13 @@ class SnapMapper : public Scrub::SnapMapReaderI { | |||
| return prefix_itr; | |||
| } | |||
|
|
|||
| #ifdef WITH_SEASTAR | |||
There was a problem hiding this comment.
This behavior is not specific to seastar, remove the ifdef.
This is a little bit tricky.
|
Matan-B
approved these changes
May 8, 2024
There was a problem hiding this comment.
This is a little bit tricky.
- Snaps
snap1andsnap2on objectobj1maps to the same clonec- Snap
snap1is being trimmed on PGP;- Before
snap1ofobj1is trimmed and after theobj1 <-> snap1mapping is removed from the snap mapper,P's interval changed;- Snap
snap2is trimmed onobj1and caused thecto be removed- The osd gets restarted and find that
snap1ofobj1hasn't been trimmed- The osd tries to trim
snap1onobj1and meet the assertioncit != std::end(ss.clones)
Ah, thanks! LGTM besides comments left by @athanatos
|
All done:-) |
Fixes: https://tracker.ceph.com/issues/65679 Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
|
jenkins test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/65679
Signed-off-by: Xuehan Xu xuxuehan@qianxin.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e