Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cephadm: change loki/promtail default image tags #57164

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

guits
Copy link
Contributor

@guits guits commented Apr 30, 2024

This commit changes the default images for both loki and promtail
containers.
Also, to allow this update we need to update the configuration of loki
in order to add a new storage schema configuration:

    - from: 2024-05-03
      store: tsdb
      object_store: filesystem
      schema: v13
      index:
        prefix: index_
        period: 24h

This is because 3.0.0 uses new structured metadata.

See [1][2].

[1] https://grafana.com/docs/loki/latest/operations/storage/schema/
[2] https://grafana.com/docs/loki/latest/get-started/labels/structured-metadata/#when-to-use-structured-metadata

Fixes: https://tracker.ceph.com/issues/65784

Signed-off-by: Guillaume Abrioux gabrioux@ibm.com

@guits guits added the cephadm label Apr 30, 2024
@guits guits requested a review from a team as a code owner April 30, 2024 13:29
@guits
Copy link
Contributor Author

guits commented Apr 30, 2024

@aaSharma14 FYI

@guits
Copy link
Contributor Author

guits commented May 3, 2024

Hey @aaSharma14 ,

I took a look at this, 3.0.0 uses new schema v13 with new structured metadata, it implies migrating from BoltDB with v11 schema to tsdb with v13 schema.
Correct me if I'm wrong but I think it means we would have to take care of backward compatibility by adding a new schema_config block.

We currently have:

schema_config:
  configs:
    - from: 2020-10-24
      store: boltdb-shipper
      object_store: filesystem
      schema: v11
      index:
        prefix: index_
        period: 24h

We would need to add something like following:

schema_config:
  configs:
    - from: 20YY-MM-DD
      store: tsdb
      object_store: filesystem
      schema: v13
      index:
        prefix: index_
        period: 24h

Another option is starting loki with -validation.allow-structured-metadata=false parameter , which is what I've done in this PR.

@aaSharma14 Let me know which approach would be best.

@guits
Copy link
Contributor Author

guits commented May 6, 2024

jenkins test make check

@guits
Copy link
Contributor Author

guits commented May 7, 2024

@adk3798 @aaSharma14 🙂

Copy link

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

This commit changes the default images for both loki and promtail
containers.
Also, to allow this update we need to update the configuration of loki
in order to add a new storage schema configuration:

```
    - from: 2024-05-03
      store: tsdb
      object_store: filesystem
      schema: v13
      index:
        prefix: index_
        period: 24h
```

This is because 3.0.0 uses new structured metadata.

See [1][2].

[1] https://grafana.com/docs/loki/latest/operations/storage/schema/
[2] https://grafana.com/docs/loki/latest/get-started/labels/structured-metadata/#when-to-use-structured-metadata

Fixes: https://tracker.ceph.com/issues/65784

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
@guits guits merged commit 441dd6f into ceph:main May 15, 2024
11 of 12 checks passed
@guits guits deleted the bump-promtail branch May 15, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants