Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/cephadm: make setting --cgroups=split configurable for adopted daemons #57205

Merged

Conversation

SidGilad
Copy link
Contributor

@SidGilad SidGilad commented May 1, 2024

Support for making --cgroups=split configurable was added in the past.
Previous support did not include adoption of legacy daemons
This commit adds support for configuring --cgroups=split when running 'adopt' command

Checklist

  • Tracker (select at least one)
    • References tracker ticket
  • Component impact

Fixes: https://tracker.ceph.com/issues/65739

Signed-off-by: Gilad Sid sid.gilad@gmail.com

@SidGilad SidGilad requested a review from a team as a code owner May 1, 2024 15:38
@phlogistonjohn
Copy link
Contributor

phlogistonjohn commented May 3, 2024

Hi there, the "Signed-off-by" needs to go into each commit message. It doesn't need to go into the PR description. While we are discussing this, I noticed your commits are authored by 'root' - which is not so great either. Plus, the commit seems duplicated with one using a nonstandard commit message style while the 2nd one is better. (Edit: To be clear the one starting with mgr/cephadm: is using the correct style but the component is actually wrong. It should just be cephadm:)

If you need assistance using git please say so and we can either try to walk you through the needed steps or intervene directly by redoing your patches (with your approval).

… legacy daemons

Signed-off-by: Gilad Sid <sid.gilad@gmail.com>
@SidGilad SidGilad force-pushed the bug/65739_support_cgroup_split_removal_for_adopt branch from 704b3d6 to 20ffd4d Compare May 5, 2024 12:39
@SidGilad
Copy link
Contributor Author

SidGilad commented May 8, 2024

jenkins retest this please

@adk3798
Copy link
Contributor

adk3798 commented May 10, 2024

https://pulpito.ceph.com/adking-2024-05-09_03:09:40-orch:cephadm-wip-adk-testing-2024-05-08-1927-distro-default-smithi/

failures:

  • 21 in cluster log type failures that are still being cleaned up, known issue
  • 3 mds_upgrade_sequence failures, known issue
  • 1 test failed installing ceph-fuse Status code: 503 for https://mirrors.centos.org/metalink?repo=centos-baseos-9-stream&arch=x86_64&protocol=https,http, happens on occasion, nothing to block merging over

Overall, nothing unexpected in the run

@adk3798
Copy link
Contributor

adk3798 commented May 10, 2024

jenkins test make check

@adk3798
Copy link
Contributor

adk3798 commented May 10, 2024

jenkins test windows

@adk3798 adk3798 merged commit 51db3f3 into ceph:main May 10, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants