-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mds: don't stall the asok thread for flush commands #57274
Conversation
This is used as the suite branch for https://pulpito.ceph.com/leonidus-2024-05-05_21:28:36-fs-wip-pdonnell-testing-20240503.163550-debug-distro-default-smithi/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine!
Conditional approve post successful test run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://tracker.ceph.com/issues/65803:#note-2
I think the simple fix is to make flush journal
asynchronous. The quiesce
command already is so please just do some similar logic there.
I'm not sure it's that simple. We can't just change a synchronous command to asynchronous, can we? We'll have to add a switch to the command and change the invocation along with verifying that it'll know how to deal with the new approach. In any case, it would probably have to be a separate ticket with its own PR... |
5c17ef6
to
e7f8941
Compare
Signed-off-by: Leonid Usov <leonid.usov@ibm.com> Fixes: https://tracker.ceph.com/issues/65803
Signed-off-by: Leonid Usov <leonid.usov@ibm.com> Fixes: https://tracker.ceph.com/issues/65803
e7f8941
to
a4dc881
Compare
In a talk with @batrick he explained that it was about not holding up the asok thread, which I followed here |
jenkins test make check |
jenkins test make check |
jenkins test make check arm64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved!
This PR is under test in https://tracker.ceph.com/issues/65867. |
@batrick please approve for merge. See #57332 (comment) |
Also, relax some timing requirements in the quiescer
Fixes: https://tracker.ceph.com/issues/65803
Show available Jenkins commands
jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows
jenkins test rook e2e