bluestore: No extra files in osd_path directory #57318
Open
+182
−318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Block device got this interface function with ceph#7145. In bluestore, bdev label just means "first disk block, located at #0". For other devices, there is deeper meaning: https://docs.pmem.io/ndctl-user-guide/managing-label-storage-areas-lsa It is most likely that two distinct features were joined by name. It is obvious that any block device will be able to write to its first block. Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
BlueStore meta values are located in superlabel block. They were exported outside to osd dir (conf.osd_data) but no one seems to need it. Now values are only in superlabel block. Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
Moved logic of detecting objectstore pointed by conf.osd_data from ceph_osd.cc to ObjectStore interface as bool ObjectStore::probe_objectstore_type(...) Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
Move creation of type=bluestore in superlabel after creation of the label. Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
If possible, extract 'osd_key' from objectstore meta variable and put it to conf.key. That way keyring file is no longer needed. Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
Now locking of bluestore is done via bdev exclusive locking. Fsid is read directly from superlabel block. Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
When open with O_EXCL fails it returns -EBUSY. So if flock fail, we set result to -EBUSY. Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
aclamk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables creation and use of files in osd_path directory.
No meta values set and persisted in superlabel block are mirrored to files.
No keyring file - key is read directly from objectstore.
No fsid file - fsid is read from superlabel block, and locking is done via bdev exclusive locking.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e