squid: mds: check relevant caps for fs include root_squash #57342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonyeleven
approved these changes
May 8, 2024
|
jenkins test make check |
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
|
This PR is under test in https://tracker.ceph.com/issues/66101. |
For testing purposes. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit d9239f9)
So we can just pass the caller's kwargs to update_attrs. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 597ff3c)
So we can pass mntargs. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit afcbfc0)
Where the client has root_squash for one cap but not for another. The fs without root_squash should not necessarily reject the client. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit bccc8ce) Conflicts: qa/tasks/cephfs/test_admin.py: missing test
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 247b4fe)
When denying client reconnects because the MDS caps include root_squash and the client features do not include CEPHFS_FEATURE_MDS_AUTH_CAPS_CHECK, ensure those caps are only for the file system the MDS is joined to. Fixes: https://tracker.ceph.com/issues/65733 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit f79ae86)
There is a "client_count" metadata on the health warning that apparently was intended to be used for aggregating warnings but never was. Add a TODO item for that. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 6517b70)
Rather than evict all clients lacking this feature bit, raise a health error that pushes the administrator to address it. This avoids the surprise of having all affected clients suddenly evicted in the cluster. Fixes: https://tracker.ceph.com/issues/65733 Fixes: 954ed30 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 66ff5c9)
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 9d0ab23)
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit b810bc9)
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 79ba897)
|
minor rebase to fix pending release note conflict |
|
jenkins test make check |
|
jenkins test api |
|
Tests in this PR ran successfully in /teuthology/pdonnell-2024-05-20_15:44:59-fs-wip-pdonnell-testing-20240517.203521-squid-debug-distro-default-smithi/7715650/teuthology.log ultimate failure was for other reasons. |
|
Ready to merge when jenkins tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/65853
backport of #57192
parent tracker: https://tracker.ceph.com/issues/65733
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh