reef: mds: check relevant caps for fs include root_squash #57343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is under test in https://tracker.ceph.com/issues/65856. |
|
jenkins test make check |
|
jenkins test windows |
batrick
added a commit
to batrick/ceph
that referenced
this pull request
May 9, 2024
* refs/pull/57343/head: PendingReleaseNotes: add note on the client incompatibility health warning and feature bit doc/cephfs: add client_mds_auth_caps client feature bit doc/cephfs: add missing client feature bits doc/cephfs: document MDS_CLIENTS_BROKEN_ROOTSQUASH health error qa: add tests for MDS_CLIENTS_BROKEN_ROOTSQUASH mds: raise health warning if client lacks feature for root_squash mon/MDSMonitor: add note about missing metadata inclusion mds: check relevant caps for fs include root_squash mds: refactor out fs_name match in MDSAuthCaps qa: test for root_squash with multiple caps qa: pass kwargs to mount from remount qa: simplify update_attrs and only update relevant keys client: allow overriding client features
|
|
|
jenkins test make check |
For testing purposes. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit d9239f9)
So we can just pass the caller's kwargs to update_attrs. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 597ff3c)
So we can pass mntargs. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit afcbfc0)
Where the client has root_squash for one cap but not for another. The fs without root_squash should not necessarily reject the client. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit bccc8ce) Conflicts: qa/tasks/cephfs/test_admin.py: missing test
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 247b4fe)
When denying client reconnects because the MDS caps include root_squash and the client features do not include CEPHFS_FEATURE_MDS_AUTH_CAPS_CHECK, ensure those caps are only for the file system the MDS is joined to. Fixes: https://tracker.ceph.com/issues/65733 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit f79ae86)
There is a "client_count" metadata on the health warning that apparently was intended to be used for aggregating warnings but never was. Add a TODO item for that. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 6517b70)
Rather than evict all clients lacking this feature bit, raise a health error that pushes the administrator to address it. This avoids the surprise of having all affected clients suddenly evicted in the cluster. Fixes: https://tracker.ceph.com/issues/65733 Fixes: 954ed30 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 66ff5c9) Conflicts: src/messages/MMDSBeacon.h: missing health beacon type
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 9d0ab23)
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit b810bc9)
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 79ba897)
|
rebased + removed some accidental additions to the PendingReleaseNotes |
|
This PR is under test in https://tracker.ceph.com/issues/65884. |
|
jenkins test make check |
batrick
force-pushed
the
wip-65855-reef
branch
2 times, most recently
from
735b54d
to
0a9fb89
Compare
batrick
added a commit
to batrick/ceph
that referenced
this pull request
May 10, 2024
* refs/pull/57343/head: SQUASH reef: qa: do not use `fs authorize` for two fs PendingReleaseNotes: add note on the client incompatibility health warning and feature bit doc/cephfs: add client_mds_auth_caps client feature bit doc/cephfs: add missing client feature bits doc/cephfs: document MDS_CLIENTS_BROKEN_ROOTSQUASH health error qa: add tests for MDS_CLIENTS_BROKEN_ROOTSQUASH mds: raise health warning if client lacks feature for root_squash mon/MDSMonitor: add note about missing metadata inclusion mds: check relevant caps for fs include root_squash mds: refactor out fs_name match in MDSAuthCaps qa: test for root_squash with multiple caps qa: pass kwargs to mount from remount qa: simplify update_attrs and only update relevant keys client: allow overriding client features
This support was only recently added in squid. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
|
jenkins test make check |
batrick
commented
May 11, 2024
batrick
commented
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/65855
backport of #57192
parent tracker: https://tracker.ceph.com/issues/65733
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh