Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reef: mon/MDSMonitor: fix assert crash in fs swap #57373

Merged
merged 1 commit into from
May 11, 2024
Merged

reef: mon/MDSMonitor: fix assert crash in fs swap #57373

merged 1 commit into from
May 11, 2024

Conversation

batrick
Copy link
Member

@batrick batrick commented May 9, 2024 •
edited by leonid-s-usov

Paxos is plugged differently between main and reef.

Fixes: f11cf2b
Fixes: https://tracker.ceph.com/issues/65883

Checklist

  • Tracker (select at least one)
    • References tracker ticket
  • Component impact
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • No doc update is appropriate
  • Tests (select at least one)
    • No tests
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@batrick batrick added this to the v18.2.3 milestone May 9, 2024
@batrick batrick requested a review from a team as a code owner May 9, 2024 13:08
@github-actions github-actions bot added cephfs Ceph File System core mon labels May 9, 2024
@batrick batrick added wip-pdonnell-testing2 and removed core cephfs Ceph File System mon labels May 9, 2024
@batrick batrick requested review from vshankar, rishabh-d-dave and a team May 9, 2024 13:11
@batrick
Copy link
Member Author

batrick commented May 9, 2024

This PR is under test in https://tracker.ceph.com/issues/65884.

@batrick batrick mentioned this pull request May 9, 2024
Merged
@vshankar
Copy link
Contributor

vshankar commented May 9, 2024

Paxos is plugged differently between main and reef.

Fixes: f11cf2b Fixes: https://tracker.ceph.com/issues/63293

This tracker is "Implement fscrypt in libcephfs and cephfs-fuse" - should be https://tracker.ceph.com/issues/65883 :)

@batrick
Copy link
Member Author

batrick commented May 9, 2024

Paxos is plugged differently between main and reef.
Fixes: f11cf2b Fixes: https://tracker.ceph.com/issues/63293

This tracker is "Implement fscrypt in libcephfs and cephfs-fuse" - should be https://tracker.ceph.com/issues/65883 :)

oops, had the wrong window open!

@batrick
mon/MDSMonitor: fix assert crash in fs swap
beae131 
Paxos is plugged differently between main and reef.

Fixes: f11cf2b
Fixes: https://tracker.ceph.com/issues/65883
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
@github-actions github-actions bot added cephfs Ceph File System core mon labels May 9, 2024
batrick added a commit to batrick/ceph that referenced this pull request May 10, 2024
@batrick
Merge PR ceph#57373 into wip-pdonnell-testing-20240509.171335-reef-debug
733527a 
* refs/pull/57373/head:
	mon/MDSMonitor: fix assert crash in `fs swap`
@batrick batrick changed the title mon/MDSMonitor: fix assert crash in fs swap reef: mon/MDSMonitor: fix assert crash in fs swap May 10, 2024
@batrick
Copy link
Member Author

batrick commented May 11, 2024

https://tracker.ceph.com/issues/65884?issue_count=14&issue_position=1&next_issue_id=65699#note-5

batrick
batrick commented May 11, 2024
View reviewed changes
Copy link
Member Author

@batrick batrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

@batrick batrick merged commit 593c8b6 into ceph:reef May 11, 2024
13 checks passed
@batrick batrick deleted the i65883 branch May 11, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vshankar vshankar Awaiting requested review from vshankar

@rishabh-d-dave rishabh-d-dave Awaiting requested review from rishabh-d-dave

Assignees
No one assigned
Labels
cephfs Ceph File System core mon wip-pdonnell-testing2
Projects
None yet
Milestone
v18.2.3
2 participants
@batrick @vshankar