rgw/pubsub: Waiter unlocks before suspend

[cbodley]

resolves a recent regression from #55592 (comment), where the unlock() was accidentally moved after the coroutine's suspend+resume

Show available Jenkins commands

• jenkins retest this please
• jenkins test classic perf
• jenkins test crimson perf
• jenkins test signed
• jenkins test make check
• jenkins test make check arm64
• jenkins test submodules
• jenkins test dashboard
• jenkins test dashboard cephadm
• jenkins test api
• jenkins test docs
• jenkins render docs
• jenkins test ceph-volume all
• jenkins test ceph-volume tox
• jenkins test windows
• jenkins test rook e2e

[cbodley]

don't want to set up a kafka, so waiting on ceph-ci to test in teuthology

[yuvalif]

don't want to set up a kafka, so waiting on ceph-ci to test in teuthology

i'll check locally. it was reproduced every time

[cbodley]

pending in https://pulpito.ceph.com/cbodley-2024-05-22_14:38:25-rgw-wip-boost-asio-spawn-unlock-distro-default-smithi/

[yuvalif]

don't want to set up a kafka, so waiting on ceph-ci to test in teuthology

i'll check locally. it was reproduced every time

kafka test are now passing localy

[cbodley]

passed qa in https://pulpito.ceph.com/cbodley-2024-05-22_18:30:21-rgw-wip-boost-asio-spawn-unlock-distro-default-smithi/ with rerun https://pulpito.ceph.com/cbodley-2024-05-23_15:42:06-rgw-wip-boost-asio-spawn-unlock-distro-default-smithi/

kafka and amqp jobs passed, http job had just the one FAIL: test pushing http s3 notification from https://tracker.ceph.com/issues/66033

[cbodley]

(no tracker issue because #55592 isn't being backported)