v18.2.3 #57634
Closed
v18.2.3 #57634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is hard for Debian/Ubuntu users to use ceph-exporter because it is not included in any deb packages. This commit adds a new deb package for ceph-exporter. Fixes: https://tracker.ceph.com/issues/64095 Signed-off-by: Shinya Hayashi <shinya-hayashi@cybozu.co.jp> (cherry picked from commit a53c065) (cherry picked from commit 0479bc6)
The `ceph-mgr` package lost its dependency on `python3-bcrypt` when the dependencies got moved from d/control to a dh_python3 compatible requires file. Add it again as the bcrypt module is still used there. Otherwise one gets errors when, e.g., calling `ceph -s` after a fresh installation: > 13 mgr modules have failed dependencies > Module 'balancer' has failed dependency: No module named 'bcrypt' > Module 'crash' has failed dependency: No module named 'bcrypt' > Module 'devicehealth' has failed dependency: No module named 'bcrypt' > Module 'iostat' has failed dependency: No module named 'bcrypt' > Module 'nfs' has failed dependency: No module named 'bcrypt' > Module 'orchestrator' has failed dependency: No module named 'bcrypt' > Module 'pg_autoscaler' has failed dependency: No module named 'bcrypt' > Module 'progress' has failed dependency: No module named 'bcrypt' > Module 'rbd_support' has failed dependency: No module named 'bcrypt' > Module 'restful' has failed dependency: No module named 'bcrypt' > Module 'status' has failed dependency: No module named 'bcrypt' > Module 'telemetry' has failed dependency: No module named 'bcrypt' > Module 'volumes' has failed dependency: No module named 'bcrypt' Fixes: https://tracker.ceph.com/issues/63637 Fixes: ef19547 ("debian: add .requires for specifying python3 deps") Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com> (cherry picked from commit adc501c) (cherry picked from commit 387b840)
Where the client has root_squash for one cap but not for another. The fs without root_squash should not necessarily reject the client. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit bccc8ce) Conflicts: qa/tasks/cephfs/test_admin.py: missing test (cherry picked from commit 22342c7)
When denying client reconnects because the MDS caps include root_squash and the client features do not include CEPHFS_FEATURE_MDS_AUTH_CAPS_CHECK, ensure those caps are only for the file system the MDS is joined to. Fixes: https://tracker.ceph.com/issues/65733 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit f79ae86) (cherry picked from commit 9b0f492)
Rather than evict all clients lacking this feature bit, raise a health error that pushes the administrator to address it. This avoids the surprise of having all affected clients suddenly evicted in the cluster. Fixes: https://tracker.ceph.com/issues/65733 Fixes: 954ed30 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 66ff5c9) Conflicts: src/messages/MMDSBeacon.h: missing health beacon type (cherry picked from commit 480b2cb)
This support was only recently added in squid. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 62328df)
A comment clearly left as a breadcrumb for a node-proxy manpage is causing (intermittent) build failures. Remove the line and hope the manpage is added if/when appropriate. Fixes: 0dd7364 Signed-off-by: John Mulligan <jmulligan@redhat.com> (cherry picked from commit 5f25005) (cherry picked from commit a75e4b6)
with arrow's default BUILD_WARNING_LEVEL, -Werror is added to cflags and debug builds fail on a warning about _FORTIFY_SOURCE Fixes: https://tracker.ceph.com/issues/63130 Signed-off-by: Casey Bodley <cbodley@redhat.com> (cherry picked from commit 5c1a57a) (cherry picked from commit 7ecee43)
github-actions
bot
added
build/ops
ceph-volume
cephfs
| Package: ceph-exporter | ||
| Architecture: linux-any | ||
| Depends: ceph-base (= ${binary:Version}), | ||
| Description: metrics exporter for the ceph distributed storage system |
This is a minimal fix to ensure only peers understanding
`pg-upmap-primary` are able to connect, and thus to exclude
the possibility of running into the `pg_upmap_primaries.empty()`
assertion in encoders.
Fixes for other problems will follow up.
The intention is to ship this patch in the very next minor
release of reef.
Manual testing
--------------
\### start using upmap-primar is presence of `quincy` client
NOTE: incompatible clients aren't disconnected but this is
known and expected as we lack the machinery.
```
[rzarzynski@o06 build]$ bin/ceph osd get-require-min-compat-client
reef
[rzarzynski@o06 build]$ bin/ceph daemon mon.a sessions | jq -jr '.[] | .name, "\t", .con_features, "\t", .con_features_hex, "\n"' | grep client
client.? 4540701547738038271 3f03cffffffdffff
client.? 4540138320759226367 3f01cfbf7ffdffff
[rzarzynski@o06 build]$ bin/ceph osd pool create test_pool 1 1
pool 'test_pool' created
[rzarzynski@o06 build]$ bin/ceph osd pg-upmap-primary 1.0 2
change primary for pg 1.0 to osd.2
[rzarzynski@o06 build]$ bin/ceph daemon mon.a sessions | jq -jr '.[] | .name, "\t", .con_features, "\t", .con_features_hex, "\n"' | grep client
client.? 4540701547738038271 3f03cffffffdffff
client.? 4540138320759226367 3f01cfbf7ffdffff
```
\### `main` client is still able to connect
```
[rzarzynski@o06 build]$ bin/ceph -w
cluster:
id: d570a7c-84ca-4fd0-aafb-80138762c6af
health: HEALTH_WARN
11 mgr modules have failed dependencies
1 pool(s) do not have an application enabled
services:
mon: 1 daemons, quorum a (age 64m)
mgr: x(active, since 64m)
osd: 3 osds: 3 up (since 64m), 3 in (since 64m)
data:
pools: 1 pools, 1 pgs
objects: 0 objects, 0 B
usage: 3.0 GiB used, 300 GiB / 303 GiB avail
pgs: 1 active+clean
```
\### `quincy` client is refused
```
[rzarzynski@o06 build-quincy]$ bin/ceph -s -c /home/rzarzynski/ceph2/build/ceph.conf
2024-05-30T08:59:42.411+0000 7f0911a9b700 -1 --2- 127.0.0.1:0/2812481872 >> [v2:127.0.0.1:40536/0,v1:127.0.0.1:40537/0] conn(0x7f090c111500 0x7f090c1118f0 secure :-1 s=SESSION_CONNECTING pgs=0 cs=0 l=0 rev1=1 crypto rx=0x7f08fc0048c0 tx=0x7f08fc009e30 comp rx=0 tx=0).handle_ident_missing_features client does not support all server features: 80000000
2024-05-30T08:59:42.612+0000 7f0911a9b700 0 --2- 127.0.0.1:0/2812481872 >> [v2:127.0.0.1:40536/0,v1:127.0.0.1:40537/0] conn(0x7f090c111500 0x7f090c1118f0 unknown :-1 s=AUTH_CONNECTING pgs=0 cs=0 l=0 rev1=1 crypto rx=0 tx=0 comp rx=0 tx=0).send_auth_request get_initial_auth_request returned -2
```
\### stop using upmap-primary
```
[rzarzynski@o06 build]$ bin/ceph osd rm-pg-upmap-primary 1.0
clear 1.0 pg_upmap_primary mapping
```
\### `quincy` client may connect again
```
[rzarzynski@o06 build-quincy]$ bin/ceph -s -c /home/rzarzynski/ceph2/build/ceph.conf
cluster:
id: d570a7c-84ca-4fd0-aafb-80138762c6af
health: HEALTH_WARN
11 mgr modules have failed dependencies
1 pool(s) do not have an application enabled
services:
mon: 1 daemons, quorum a (age 77m)
mgr: x(active, since 77m)
osd: 3 osds: 3 up (since 76m), 3 in (since 76m)
data:
pools: 1 pools, 1 pgs
objects: 0 objects, 0 B
usage: 3.0 GiB used, 300 GiB / 303 GiB avail
pgs: 1 active+clean
```
Fixes: https://tracker.ceph.com/issues/61948
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
(cherry picked from commit 5dbb7c4)
Conflicts:
src/osd/OSDMap.cc -- reef lacks MSR
(cherry picked from commit 9fb3902)
Unit testing ------------- ``` [rzarzynski@o06 build]$ bin/unittest_features ... [ RUN ] features.release_features 1 argonaut features 0x40000 looks like argonaut 2 bobtail features 0x40000 looks like argonaut 3 cuttlefish features 0x40000 looks like argonaut 4 dumpling features 0x42040000 looks like dumpling 5 emperor features 0x42040000 looks like dumpling 6 firefly features 0x20842040000 looks like firefly 7 giant features 0x20842040000 looks like firefly 8 hammer features 0x1020842040000 looks like hammer 9 infernalis features 0x1020842040000 looks like hammer 10 jewel features 0x401020842040000 looks like jewel 11 kraken features 0xc01020842040000 looks like kraken 12 luminous features 0xe01020842240000 looks like luminous 13 mimic features 0xe01020842240000 looks like luminous 14 nautilus features 0xe01020842240000 looks like luminous 15 octopus features 0xe01020842240000 looks like luminous 16 pacific features 0xe01020842240000 looks like luminous 17 quincy features 0xe01020842240000 looks like luminous 18 reef features 0xe010208d2240000 looks like reef 19 squid features 0xe010208d2240000 looks like reef [ OK ] features.release_features (0 ms) ``` Manual testing -------------- \### 'quincy` client connected to `main` cluster There was `ceph -w` from `quincy` running in the background. ``` [rzarzynski@o06 build]$ bin/ceph osd set-require-min-compat-client reef Error EPERM: cannot set require_min_compat_client to reef: 1 connected client(s) look like luminous (missing 0x80000000); add --yes-i-really-mean-it to do it anyway ``` \### Only `main` clients connected to `main` cluster ``` [rzarzynski@o06 build]$ bin/ceph osd get-require-min-compat-client luminous [rzarzynski@o06 build]$ bin/ceph daemon mon.a sessions | jq -jr '.[] | .name, "\t", .con_features, "\t", .con_features_hex, "\n"' | grep client client.? 4540701547738038271 3f03cffffffdffff client.? 4540701547738038271 3f03cffffffdffff [rzarzynski@o06 build]$ bin/ceph osd set-require-min-compat-client reef set require_min_compat_client to reef ``` Fixes: https://tracker.ceph.com/issues/61948 Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com> (cherry picked from commit 4d74ff6) (cherry picked from commit 70adcbb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e