test/rgw/notifications: skip reload tests when there is no realm #57639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this does not impact teuthology, only local runs. in teuthology all bucket notification tests are defined with a realm Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
|
reload and migration tests are passing: |
AliMasarweh
approved these changes
May 23, 2024
| @@ -4536,6 +4536,9 @@ def test_ps_s3_notification_push_kafka_security_sasl_scram(): | |||
| @attr('http_test') | |||
| def test_persistent_ps_s3_reload(): | |||
| """ do a realm reload while we send notifications """ | |||
There was a problem hiding this comment.
this test is supposed to reload the realm while we send notifications,
however I see we only enable v2 notifications without disabling them at the start of the test
https://github.com/ceph/ceph/pull/57639/files#diff-83b1d2148e5a0483255b9af5f707fec576625a16c04aca191578d555ca336443R4617
but we can fix it in a different PR
There was a problem hiding this comment.
can you please open a tracker (we should backport to squid) for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this does not impact teuthology, only local runs.
in teuthology all bucket notification tests are defined with a realm
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e