reef: common,ceph: add output file switch to dump json to #57676
+311
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 770ab51)
To stream JSON to a file for collection (for testing). The idea here that trying to send a very large JSON result over `ceph tell` is best to be avoided. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 8928a12)
The formatter would be deleted and automatically flush anyway but this is conforming to the API. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 5a3584b)
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit de350cc)
The `ceph tell mds.X cache dump` and `ceph tell mds.X ops` commands have a useful `--path` argument that directs the daemon to save the dump of the output to a file local the daemon. This has several advantages: * We don't need to construct the JSON output in memory, which may be many gigabytes. * Streaming writes to a local file is significantly faster than sending the data over the ceph messenger. * The command spends as little time as possible holding relevant locks. However, only some commands support this and we could make it generic to the admin socket interface. So, add a generic --daemon-output-file argument to achieve this. The main concern with this is security (telling the daemon to write to arbitrary files) but this is gated by the session caps which require "allow_all" and that's typically only valid for the client.admin. Fixes: https://tracker.ceph.com/issues/65747 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit a341468)
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 2d26694)
Its path/name include random characters making it unsuitable for static diffs. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit cd780f0)
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 8664fe9)
|
Includes some commits from the quiesce work to make this backportable. |
|
jenkins test make check |
2 similar comments
|
jenkins test make check |
|
jenkins test make check |
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/66187
backport of #57215
parent tracker: https://tracker.ceph.com/issues/65747
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh