Miscellaneous spec file fixes 1 #5788
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dachary, @Abhishekvrshny In this PR I have combined several spec file fixes. Hopefully this will reduce the amount of specfile merge conflicts you have to deal with. |
|
@ldachary sounds like a nice idea to me :-) |
|
Just in case anyone is wondering, we had a large number of spec file fixes in master recently. They need to be backported, but backporting them individually is problematic (merge conflicts). |
|
@smithfarm clustering them into a single pull request makes a lot of sense, good idea ! You may want to update the pull request title to reflect that. |
smithfarm
changed the title
smithfarm
changed the title
ghost
mentioned this pull request
ghost
pushed a commit
that referenced
this pull request
Oct 2, 2015
Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Oct 3, 2015
Reviewed-by: Loic Dachary <ldachary@redhat.com>
Given ceph's reputation for voluminous logs, it makes sense for logrotate to be a hard dependency for all distros. Signed-off-by: Nathan Cutler <ncutler@suse.com> (cherry picked from commit 0734cd1)
Automatically create /var/lib/ceph/radosgw with the ceph-radosgw package, and /var/lib/ceph/bootstrap-rgw via the ceph package. Signed-off-by: Travis Rhoden <trhoden@redhat.com> (cherry picked from commit bf93128) Conflicts: ceph.spec.in hammer uses %ghost
smithfarm
force-pushed
the
wip-12925-hammer
branch
from
5baa6a2
to
0a08b47
Compare
ghost
pushed a commit
that referenced
this pull request
Oct 3, 2015
Reviewed-by: Loic Dachary <ldachary@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/12925
http://tracker.ceph.com/issues/11732