erasure-code: fix gf-complete warnings #5829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to the latest gf-complete v2 branch which has the compilation warning fixed. In addition the default compilation flag upstream has been set to display such warnings. git log --oneline --graph d384952c68a64d93ac7af6341d5519ea5d2958b9..9caeefbf2860e56a75502f4d3342deed5b5ba265 * 9caeefb add -Wsign-compare and address the warnings * 5979f98 gf_w64.c: fix integer overflow * 93a9845 gf_w64.c: fix integer overflow * 513c87b gf_w64.c: fix integer overflow * 4d6fa89 gf_w64.c: fix integer overflow http://tracker.ceph.com/issues/12731 Fixes: #12731 Signed-off-by: Loic Dachary <ldachary@redhat.com>
ghost
added
|
the upstream changes look good to me and the jerasure plugin compiles without any warnings!
|
|
@liewegas is running the erasure code thrashing jerasure jobs of the rados suite (details at http://tracker.ceph.com/issues/12731#note-9) enough QA ? |
|
@tchaikov thanks for embarking this pull request in your rados run, much appreciated :-) |
tchaikov
added a commit
that referenced
this pull request
Sep 9, 2015
erasure-code: fix gf-complete warnings Reviewed-by: Kefu Chai <kchai@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to the latest gf-complete v2 branch which has the compilation
warning fixed. In addition the default compilation flag upstream has
been set to display such warnings.
git log --oneline --graph d384952c68a64d93ac7af6341d5519ea5d2958b9..9caeefbf2860e56a75502f4d3342deed5b5ba265
http://tracker.ceph.com/issues/12731 Fixes: #12731
Signed-off-by: Loic Dachary ldachary@redhat.com