Use the uuid we've created the partition with #6021
Conversation
ghost
self-assigned this
|
Could you rebase this on top of #5999 ? On that occasion if you could split the commit in two (one for partuuid and one for lvm support) it would be great :-) |
|
partuuid is lvm support. Did you mean one for ceph-disk and one for tests? |
|
@joejulian you're right, I'm impressed by the simplicity of the patch ... and I now better understand why you suggested it's treated like a bug fix and not a new feature :-) |
joejulian
force-pushed
the
joejulian-infernalis-use_lvm_block_devices
branch
from
fc9611e
to
4f50e27
Compare
| osd_uuid = str(uuid.uuid1()) | ||
| c.sh("ceph-disk zap " + lv) | ||
| c.sh("ceph-disk prepare --osd-uuid " + osd_uuid + | ||
| " " + lv) |
There was a problem hiding this comment.
c.wait_for_osd_up(osd_uuid)
because udev / systemd / upstart is asyncrhonous
Simplify and be more accurate with finding the new partition by using the uuid we created the partition with instead of guessing what the next device name will be. Fall back to the old way for distributions that don't include udev >= 211 Add tests for lvm based osds. Don't run this test with udev < 211 Signed-off-by: Joe Julian <jjulian@io.com>
joejulian
force-pushed
the
joejulian-infernalis-use_lvm_block_devices
branch
from
4f50e27
to
142af42
Compare
|
http://pulpito.ceph.com/sage-2015-09-28_14:10:55-ceph-deploy-wip-sage-testing---basic-vps/ a couple failures. both with dmcrypt, but one of them was trusty. @dachary ? |
|
@liewegas the dmcrypt ceph-deploy failure was also see on trusty, once. I'm still investigating. |
|
We stabilized the ceph-disk / ceph-deploy usage and I don't feel confident adding even the smallest change for the infernalis release. It would however be a good candidate for backport for the next infernalis point release. |
|
@joejulian please retarget this at master branch? |
|
@joejulian closing since you'll re-open a new one on master |
ghost
closed this
Simplify and be more accurate with finding the new partition
by using the uuid we created the partition with instead of guessing what
the next device name will be.
Fall back to the old way for distributions that don't include
udev >= 211
Add tests for lvm based osds. Don't run this test with udev < 211
Signed-off-by: Joe Julian jjulian@io.com