-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Omap small bugs #6046
Closed
Closed
Omap small bugs #6046
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
14b67e3
osd/ReplicatedPG: It should call clear_omap_digest.
majianpeng 39bc156
osd/ReplicatedPG: for omapclear/omaprmkeys no neet set FLAG_OMAP.
majianpeng 323fd52
osd/ReplicatedPG: for omapsetheader, remove the duplicated code.
majianpeng ee5ccfb
osd/ReplicatedPG: For omapclear/omaprmkeys, no need call touch.
majianpeng 9368cff
osd/ReplicatedBackend: Don't forget reset_tp_timeout for first read.
majianpeng d5280fb
osd/ReplicatedBackend: Check omap whether exist for get omap when do …
majianpeng 5e64e50
osd/ECBackend: optimize get_hashinfo for be_deep_scrub.
majianpeng 2e52d07
osd/ECBackend: Remove then unused code.
majianpeng f9b321e
osd/PGBackend: Don't change error type from DEEP_ERROR to SHALLOW_ERROR.
majianpeng 481ad31
osd/ReplicatedPG: for copy_get get omap, firstly check ob whether has…
majianpeng File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a comment above that says that the shallow error here takes precedence because this can be seen by both kinds of scrubs. This is a bit odd, but I'd say remove this entire commit unless you are seeing a particular problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... making shallow take precedence doesn't make sense to me. Anybody remember why it says that? @athanatos ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liewegas In addition to your change at line 412 we should not set read_error in be_scan_list() on stat() errors and set the stat size to something invalid instead. Also, remove the comments at line 374 and at line 407.
This way a regular scrub will never get a DEEP_ERROR from this function, but a deep-scrub could possibly see a SHALLOW_ERROR if only stat() fails. This keeps the error counts from getting messed up.