Bug #13207: Rados Gateway: Anonymous user is able to read bucket with authenticated read ACL #6057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yehudasa |
|
@rahul1aggarwal I understand. My question was about the specific lines change in rgw_op.cc. |
ghost
added
the
|
@rahul1aggarwal , |
…enticated read ACL Signed-off-by: root <rahul.1aggarwal@gmail.com>
|
@oritwas , |
oritwas
added a commit
that referenced
this pull request
Nov 19, 2015
Bug #13207: Rados Gateway: Anonymous user is able to read bucket with authenticated read ACL
|
@oritwas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for http://tracker.ceph.com/issues/13207
The public user id in rados gateway is "anonymous" defined by RGW_USER_ANON_ID
During a public read of a bucket (for example by generating a public url and accessing it), the method to know whether the user is public or not, the id is being compared with the public user group's uri and not with RGW_USER_ANON_ID. This led to the public user being considered as an authenticated user and hence read of a bucket is working even when the canned acl for the bucket is set to "authenticated-read".
Also, the bucket_acl object is always being created of the base type RGWAccessControlPolicy while it should be created based on the dialect of the the request (s3 or swift)