ceph-objectstore-tool: delete ObjectStore::Sequencer after umount #6113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
|
Nice.. 👍 |
An ObjectStore::Sequencer provided to an ObjectStore must not be deallocated before umount. The ObjectStore::Sequencer may hold a pointer to the instance with no reference counting. If a Context completes after the ObjectStore::Sequencer is deleted, it could try to use it and fail. http://tracker.ceph.com/issues/13176 Fixes: #13176 Signed-off-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Sep 30, 2015
ceph-objectstore-tool: delete ObjectStore::Sequencer after umount Reviewed-by: David Zafman <dzafman@redhat.com>
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An ObjectStore::Sequencer provided to an ObjectStore must not be
deallocated before umount. The ObjectStore::Sequencer may hold a pointer
to the instance with no reference counting. If a Context completes after
the ObjectStore::Sequencer is deleted, it could try to use it and fail.
http://tracker.ceph.com/issues/13176 Fixes: #13176
Signed-off-by: Loic Dachary ldachary@redhat.com