cls: new force-promotion flag for class methods #6217
Conversation
Class methods that use the cls_get_request_origin should not be proxied to a base tier -- otherwise the origin will reflect the cache tier instead of the client. Fixes: ceph#13380 Signed-off-by: Jason Dillaman <dillaman@redhat.com>
|
Verified rbd/cli/{base/install.yaml cachepool/small.yaml clusters/fixed-1.yaml features/object_map.yaml fs/btrfs.yaml msgr-failures/few.yaml workloads/rbd_cli_copy.yaml} test case now passes |
|
It seems like making Message::get_orig_source_inst() actually have the original source instance would be more generally useful. It seems like having inaccurate addrs could cause scheduling problems for forwarded requests otherwise. |
|
I thought about adding the client data -- but since the proxy ops are just forwarding the standard op, the message payload would need to be expanded to include the originator. Then I thought it might introduce a (minor) security hole since at that point, anybody could craft a message saying that they were anybody (without adding additional logic to stop bad actors). In the long term, I think forwarding the origin fits in nicely with a future capability to forward / act-on-the-behalf-of clients. |
|
Passed tests |
cls: new force-promotion flag for class methods Reviewed-by: Sage Weil <sage@redhat.com> Reviewed-by: Samuel Just <sjust@redhat.com>
Class methods that use the cls_get_request_origin should not be
proxied to a base tier -- otherwise the origin will reflect the
cache tier instead of the client.
Fixes: #13380
Signed-off-by: Jason Dillaman dillaman@redhat.com