common: fix reset max in Throttle using perf reset command #6300
Conversation
|
@dachary , please review it. |
|
@XinzeChi could you please explain in the commit message why and how this patch fixes the problem ? |
ghost
self-assigned this
XinzeChi
force-pushed
the
wip-throttle-max
branch
from
95346a6
to
108b940
Compare
|
repush based on @dachary 's comment. |
|
@dachary , when the data.type is PERFCOUNTER_U64, the reset function would not reset it. |
|
@XinzeChi right... I got it backwards |
|
@XinzeChi so, what you want with this patch is to be able to call reset() so that it does not reset l_throttle_max to zero, right ? |
|
Should this also be done for l_throttle_val ? |
we could not reset max to 0 in Throttle using perf reset command, such as throttle-osd_client_messages, throttle-filestore_bytes and so on. If we call PerfCountersBuilder::add_u64, the data.type would be PERFCOUNTER_U64. the reset function would skip it if data.type is PERFCOUNTER_U64. Fixes: ceph#13517 Signed-off-by: Xinze Chi <xinze@xsky.com>
XinzeChi
force-pushed
the
wip-throttle-max
branch
from
108b940
to
eea4026
Compare
|
@dachary , Yes, We should also do it for l_throttle_val . Thanks. |
Reviewed-by: Loic Dachary <ldachary@redhat.com> after a test suite passes. |
|
@XinzeChi are you willing to run a rados suite with this patch ? I don't see why it would fail anything but better be safe ;-) |
|
I'm afraid I don't have the authority to run a rados suite. @tchaikov would help to run a test suite later. Thanks. |
|
@XinzeChi will collect more needs-qa pr, and run them in a batch. |
common: fix reset max in Throttle using perf reset command Reviewed-by: Loic Dachary <ldachary@redhat.com>
we could not reset max to 0 in Throttle using perf reset command,
such as throttle-osd_client_messages, throttle-filestore_bytes and so on.
Fixes: #13517
Signed-off-by: Xinze Chi xinze@xsky.com