Solaris Librados Port #6416
Merged
Solaris Librados Port #6416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
rohanmars
force-pushed
the
wip-solaris-port
branch
from
9e89c55
to
f1b1a10
Compare
rohanmars
force-pushed
the
wip-solaris-port
branch
from
f1b1a10
to
99efd15
Compare
|
@rohanmars all commits are missing Signed-off-by tag |
|
very close! just a few cosmetic items, and the Signed-off-by tags. Thanks! |
…/setter Signed-off-by: Rohan Mars <code@rohanmars.com>
Signed-off-by: Rohan Mars <code@rohanmars.com>
Signed-off-by: Rohan Mars <code@rohanmars.com>
Signed-off-by: Rohan Mars <code@rohanmars.com>
Signed-off-by: Rohan Mars <code@rohanmars.com>
Signed-off-by: Rohan Mars <code@rohanmars.com>
Signed-off-by: Rohan Mars <code@rohanmars.com>
| int r = ::sendmsg(sd, msg, MSG_NOSIGNAL | (more ? MSG_MORE : 0)); | ||
| int r; | ||
| #if defined(MSG_NOSIGNAL) | ||
| r = ::sendmsg(sd, msg, MSG_NOSIGNAL | (more ? MSG_MORE : 0)); |
There was a problem hiding this comment.
@liewegas do we really need nosignal? could we handle signal interrupt at Messenger?
There was a problem hiding this comment.
Hrm, hard to say what that was breaking before. Maybe it's not a problem..
Signed-off-by: Rohan Mars <code@rohanmars.com>
rohanmars
force-pushed
the
wip-solaris-port
branch
from
99efd15
to
131deb3
Compare
|
looks good to me! let's make sure we didn't break anything. :) |
liewegas
added a commit
that referenced
this pull request
Nov 15, 2015
librados: Solaris port Reviewed-by: Sage Weil <sage@redhat.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rohan Mars code@rohanmars.com