hammer: osd: FileStore: potential memory leak if getattrs fails. #6420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Memory leak happens if _fgetattrs encounters some error and simply returns. Fixes: ceph#13597 Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn> (cherry picked from commit ace7dd0)
ghost
pushed a commit
that referenced
this pull request
Nov 11, 2015
…s fails. Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Nov 13, 2015
…s fails. Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Nov 16, 2015
…s fails. Reviewed-by: Loic Dachary <ldachary@redhat.com>
| @@ -3780,6 +3780,7 @@ int FileStore::_fgetattrs(int fd, map<string,bufferptr>& aset) | |||
| dout(10) << " -ERANGE, got " << len << dendl; | |||
| if (len < 0) { | |||
| assert(!m_filestore_fail_eio || len != -EIO); | |||
| delete[] names2; | |||
There was a problem hiding this comment.
May be it's better to use std::unique_ptr to avoid the same issue if code changes?
|
@xiexingguo Please note the question at #6420 (comment) |
ghost
pushed a commit
that referenced
this pull request
Nov 19, 2015
…s fails. Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Nov 19, 2015
…s fails. Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Nov 19, 2015
…s fails. Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
@tchaikov does this backport look good to merge ? It passed a run of the hammer rados suite ( see http://tracker.ceph.com/issues/13356#note-28 for details ). |
|
@dachary lgtm. |
ghost
pushed a commit
that referenced
this pull request
Nov 23, 2015
FileStore: potential memory leak if getattrs fails. Reviewed-by: Kefu Chai <kchai@redhat.com>
ghost
merged commit 
ghost
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/13637