fix: use right init_flags to finish CephContext #6549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 12, 2015 16:10
The constructor of RadosClient will use CephContext, and RadosClient.connect func will *always* use 0 as init_flags to call common_init_finish. So, save the init_flags to CephContex, will let RadosClient.connect use right init_flags to finish the cct. Signed-off-by: Yunchuan Wen <yunchuan.wen@kylin-cloud.com>
Signed-off-by: Yunchuan Wen <yunchuan.wen@kylin-cloud.com>
|
Nice catch! I think this explains some odd behavior we saw when trying to decouple the rbd cli from ceph internals more. lgtm! |
|
@jdurgin this passed rados suite. safe to merge, or do you want to run it through rbd first? |
jdurgin
added a commit
that referenced
this pull request
Nov 15, 2015
fix: use right init_flags to finish CephContext Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constructor of RadosClient will use CephContext,
and RadosClient.connect func will always use 0 as
init_flags to call common_init_finish.
So, save the init_flags to CephContex, will let
RadosClient.connect use right init_flags to finish
the cct.