hammer: tools: race condition in rados bench #6791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 3, 2015 14:18
When doing seq and rand read benchmarks using rados bench, a quite large portion of cpu time is consumed by doing object verification. This patch adds an option to disable this verification when it's not needed, in turn giving better cluster utilization. rados -p storage bench 600 rand scores without --no-verification: Total time run: 600.228901 Total reads made: 144982 Read size: 4194304 Bandwidth (MB/sec): 966 Average IOPS: 241 Stddev IOPS: 38 Max IOPS: 909522486 Min IOPS: 0 Average Latency: 0.0662 Max latency: 1.51 Min latency: 0.004 real 10m1.173s user 5m41.162s sys 11m42.961s Same command, but with --no-verify: Total time run: 600.161379 Total reads made: 174142 Read size: 4194304 Bandwidth (MB/sec): 1.16e+03 Average IOPS: 290 Stddev IOPS: 20 Max IOPS: 909522486 Min IOPS: 0 Average Latency: 0.0551 Max latency: 1.12 Min latency: 0.00343 real 10m1.172s user 4m13.792s sys 13m38.556s Note the decreased latencies, increased bandwidth and more reads performed. Signed-off-by: Piotr Dałek <piotr.dalek@ts.fujitsu.com> (cherry picked from commit ca6abca) Conflicts: src/common/obj_bencher.cc src/common/obj_bencher.h
Under certain conditions (like bench seq/rand -b 1024 -t 128) it is possible that aio_read reads data into destination buffers before or during memcmp execution, resulting in "[..] is not correct!" errors even if actual objects are perfectly fine. Also, moved latencty calculation around, so it is no longer affeted by memcmp. Signed-off-by: Piotr Dałek <piotr.dalek@ts.fujitsu.com> Conflicts: src/common/obj_bencher.cc
ghost
pushed a commit
that referenced
this pull request
Jan 11, 2016
Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Jan 11, 2016
Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Jan 11, 2016
Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
@athanatos does this backport look good to merge ? It passed a run of the hammer rados suite ( see http://tracker.ceph.com/issues/13356#note-34 for details ) and the upgrade/hammer suite ( see http://tracker.ceph.com/issues/13356#note-37 for details ). |
ghost
pushed a commit
that referenced
this pull request
Jan 15, 2016
Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Jan 29, 2016
Reviewed-by: Loic Dachary <ldachary@redhat.com>
liewegas
added a commit
that referenced
this pull request
Jan 31, 2016
ghost
changed the title
ghost
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PR #5152 (tools: fix race condition in seq/rand bench) to Hammer. Started at #5812 but turned out to be difficult to backport, hence this PR which consists of commits cherry-picked from master and tailored for Hammer. Tracker issue http://tracker.ceph.com/issues/12949 which is a backport of 12947
Signed-off-by: Piotr Dałek piotr.dalek@ts.fujitsu.com