FileJournal: New journal padding mode #6856
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
XinzeChi
force-pushed
the
wip-padding-journal
branch
from
407c9cb
to
8c70cd4
Compare
|
Benchmark result: Intel(R) Xeon(R) CPU E5-2620 v2 @ 2.10GHz |
|
@liewegas , Please review it. Thanks. |
XinzeChi
force-pushed
the
wip-padding-journal
branch
from
8c70cd4
to
86d3882
Compare
Current, because the requirement of DirectIo, the padding mode is adding padding data for every entry. In fact, we fetch a couple of entries as a system write as possible as can. So we only make sure system-write content met the requirement of DirectIO. We adding a padding entry at the end of system-write content(for most case, this include a couple of entries). User could set the osd_journal_padding_ahead to decide which mode. osd_journal_padding_ahead = true is good choice for pcie-ssd. Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com> Signed-off-by: Xinze Chi <xinze@xsky.com>
XinzeChi
force-pushed
the
wip-padding-journal
branch
from
86d3882
to
33ab6a3
Compare
| @@ -643,7 +644,11 @@ int FileJournal::_fdump(Formatter &f, bool simple) | |||
| &bl, | |||
| &seq, | |||
| &ss); | |||
| if (result != SUCCESS) { | |||
| if (result == SKIP) { | |||
| seq = pre_seq; | |||
There was a problem hiding this comment.
would it be simpler to make do_read_entry not clobber &seq when returning SKIP?
|
is this still current ? If yes, it needs a rebase ;-) |
|
We want to focus efforts on optimizations with BlueStore. Close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current, because the requirement of DirectIo, the padding mode
is adding padding data for every entry.
In fact, we fetch a couple of entries as a system write as possible
as can. So we only make sure system-write content met the requirement
of DirectIO. We adding a padding entry at the end of system-write
content(for most case, this include a couple of entries).
User could set the osd_journal_padding_ahead to decide which mode.
osd_journal_padding_ahead = true is good choice for pcie-ssd.
This work is base on #5877.
Signed-off-by: Jianpeng Ma jianpeng.ma@intel.com
Signed-off-by: Xinze Chi xinze@xsky.com