Osd shutdown fix #7013
Closed
Osd shutdown fix #7013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will shutdown anyway, no need to bother other peers. Signed-off-by: Xiaoxi Chen <xiaoxi.chen@intel.com>
Shutdown() will close and destory pipe, send message after shutdown() will triger a segmentation fault. Fixes:14150 Signed-off-by: Xiaoxi Chen <xiaoxi.chen@intel.com> Signed-off-by: Xiaojuan Liu <xiaojuan.liu@intel.com>
|
@xiaoxichen This seems to be a duplicated fix with #6916 proposed by me, am I right? |
|
@xiaoxichen, #6916 looks more reasonable. |
|
@XinzeChi and @xiexingguo , thx,will close it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c760789 is a cleanup that skip hb_peers update when we plan to shutdown.
4e33bf5 is a bug fix for bug #14150