New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
time: Make ceph_time clocks work under BSD #7340
Conversation
1b58dab
to
8955c3b
Compare
Linux's naming things _COARSE is non-standard. Other systems name them other non-standard things. BSD names them _FAST. Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
8955c3b
to
8395059
Compare
common: ake ceph_time clocks work under BSD Reviewed-by: Erwan Velu <erwan@redhat.com>
On 31-1-2016 09:28, Mykola Golub wrote:
Hi Mykola, I sort of prefer the approach where it is made more explicit, and put at If you prefer you way of porting, then perhaps src/include/compat.h --WjW |
I am fine with any approach. I just was pointing to yet another possible, which still is not perfect as it might be confusing. I suppose, a better solution would be to define in ceph_time.h a wrapper function ceph_clock_gettime() and constants CEPH_CLOCK_REALTIME..., so the changes are localized. But again I am fine with any fix. |
I have a fix in adamemerson@5477424 If it works for people I'll send another pull request. |
Wrong commit. I'll just link to the branch https://github.com/adamemerson/ceph/commits/wip-bsd-time-second-try |
On 1-2-2016 16:47, Adam C. Emerson wrote:
In my work last night I added the "std" workaround to this blob of code --WjW |
All right, I now have pull request #7466 submitted that should take care of this. |
Signed-off-by: Adam C. Emerson aemerson@redhat.com