Make ceph tool behave more kindly when it can't connect #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We might have cluster_handle defined, but not have successfully connected. Instead, check if it's in the connected state. Signed-off-by: Greg Farnum <greg@inktank.com>
Set up a check_for_local_options() function and a try_failure_options() function. If we have "local options" (presently just "--help"), set a 2-second timeout on the cluster connection; if we fail, go into try_failure_options(). try_failure_options() will do whatever is appropriate given the passed-in commands; again, right now it just prints out the help text if that was asked for. To facilitate this and let people work around extreme network issues, add a "--cluster-timeout" option and pass that into the cluster connect() function. This can now be used to override our new default 2-second timeout on --help, or to set a timeout after which other commands will give up (they presently will try forever). Signed-off-by: Greg Farnum <greg@inktank.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add the option to time out on all functions, and set a default timeout when --help is called, in order to print out what help is available locally.