tests: ceph-disk.sh should compare with the resolved path #7554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kefu Chai <kchai@redhat.com>
|
last time I checked, realpath is not available by default. Maybe this changed since we do not support older versions |
|
@dachary yeah, realpath was introduced in coreutils 8.15. and
and realpath is easier to understand in comparison with |
|
@tchaikov the only reason for not using realpath was because it is was not found on all supported platforms. All good :-) Reviewed-by: Loic Dachary <ldachary@redhat.com> |
tchaikov
added a commit
that referenced
this pull request
Feb 7, 2016
tests: ceph-disk.sh should compare with the resolved path Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
thanks for your review, Loïc! first merge in the new year! |
|
@tchaikov happy new lunar year ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kefu Chai kchai@redhat.com