rgw: add support for caching of Keystone admin token. #7630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzarzynski
force-pushed
the
wip-rgw-admin-token-cache
branch
from
de1886e
to
7da8a94
Compare
|
@yehudasa This PR has been verified using Tempest, s3-tests and manually. I'm removing the DNM tag right now. |
rzarzynski
changed the title
|
@rzarzynski this PR will need to be refactored on top of the v3 code |
Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>
|
@yehudasa rework is in progress. |
rzarzynski
force-pushed
the
wip-rgw-admin-token-cache
branch
from
7da8a94
to
97f789c
Compare
rzarzynski
changed the title
Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>
rzarzynski
force-pushed
the
wip-rgw-admin-token-cache
branch
from
97f789c
to
18da92f
Compare
rzarzynski
changed the title
|
@yehudasa I've rebased and retested this PR after merging the Keystone v3 support. |
| @@ -6,6 +6,12 @@ | |||
|
|
|||
| #include "rgw_common.h" | |||
|
|
|||
| int open_cms_envelope(CephContext *cct, string& src, string& dst); | |||
There was a problem hiding this comment.
@rzarzynski please add rgw_ prefix to all the utility functions that are not static anymore
There was a problem hiding this comment.
@yehudasa added.
Slightly improve code formatting and const-correctness as well. Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>
yehudasa
added a commit
that referenced
this pull request
Feb 27, 2016
rgw: add support for caching of Keystone admin token. Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
|
Changelog:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/16110