mon: OSDMonitor: Make 'osd pool rename' idempotent #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| wait_for_finished_proposal(new Monitor::C_Command(mon, m, ret, rs, get_last_committed())); | ||
| return true; | ||
| goto reply; | ||
| } while (false); |
There was a problem hiding this comment.
i think this do {} block is just confusing the flow. why not do a simple set of checks, like
if (src < 0 && dst >= 0) {
blah; err = 0;
goto reply;
}
'ceph osd pool rename' takes two arguments: source pool and dest pool. If by chance 'source pool' does not exist and 'destination pool' does, then, in order to assure it's idempotent, we want to assume that if 'source pool' no longer exists is because it was already renamed. However, while we will return success in such case, we want to make sure to let the user know that we made such assumption. Mostly to warn the user of such a thing in case of a mistake on the user's part (say, the user didn't notice that the source pool didn't exist, while the dest did), but also to make sure that the user is not surprised by the command returning success if the user expected an ENOENT or EEXIST. Fixes: #6635 Signed-off-by: Joao Eduardo Luis <joao.luis@inktank.com>
If we get dup pool rename requests that are racing, make sure the second one comes back with 'success' if the rename entry already exists in the pending_inc map. Signed-off-by: Sage Weil <sage@inktank.com>
liewegas
pushed a commit
that referenced
this pull request
Oct 26, 2013
mon: OSDMonitor: Make 'osd pool rename' idempotent Reviewed-by: Sage Weil <sage@inktank.com> Reviewed-by: Joao Eduardo Luis <joao.luis@inktank.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'ceph osd pool rename' takes two arguments: source pool and dest pool.
If by chance 'source pool' does not exist and 'destination pool' does,
then, in order to assure it's idempotent, we want to assume that if
'source pool' no longer exists is because it was already renamed.
However, while we will return success in such case, we want to make sure
to let the user know that we made such assumption. Mostly to warn the
user of such a thing in case of a mistake on the user's part (say, the
user didn't notice that the source pool didn't exist, while the dest did),
but also to make sure that the user is not surprised by the command
returning success if the user expected an ENOENT or EEXIST.
Fixes: #6635
Signed-off-by: Joao Eduardo Luis joao.luis@inktank.com