ceph-disk: make some arguments as required if necessary #7687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no default value for these arguments, and they are necessary. Then make them as required. Fixes 9666 Signed-off-by: Dongsheng Yang <dongsheng.yang@easystack.cn>
ghost
changed the title
|
Simple and elegant solution, thanks :-) |
ghost
pushed a commit
that referenced
this pull request
Feb 23, 2016
ceph-disk: make some arguments as required if necessary Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
merged commit
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no default value for these arguments, and they are
necessary. Then make them as required.
Fixes 9666
Signed-off-by: Dongsheng Yang dongsheng.yang@easystack.cn