Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

journal: re-use common threads between journalers #7906

Merged
merged 4 commits into from Mar 9, 2016

Conversation

dillaman
Copy link

@dillaman dillaman commented Mar 3, 2016

The rbd-mirror daemon will instantiate potentially thousands of journalers. To avoid spawning two threads per journaler, now rbd-mirror can reuse the same threads between journalers.

@dillaman dillaman changed the title [DNM] journal: re-use common threads between journalers journal: re-use common threads between journalers Mar 3, 2016
@jdurgin
Copy link
Member

jdurgin commented Mar 8, 2016

TestJournalPlayer.PrefetchSkippedObject failed in the make check bot

Jason Dillaman added 4 commits March 8, 2016 07:11
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
This avoids the need to open two threads per journaler.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
This is the first step in merging the journal threads into the
librbd singleton thread pool.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
@dillaman
Copy link
Author

dillaman commented Mar 8, 2016

@jdurgin I was able to repeat that failure on master -- I'll fix it under PR #7884 if it's still an issue after the code changes made to JournalPlayer in that commit.

@dillaman
Copy link
Author

dillaman commented Mar 8, 2016

@jdurgin Unable to repeat the issue under PR #7884 branch

@dillaman dillaman added this to the jewel milestone Mar 8, 2016
@jdurgin jdurgin merged commit 7fd230f into ceph:master Mar 9, 2016
jdurgin added a commit that referenced this pull request Mar 9, 2016
journal: re-use common threads between journalers

Conflicts:
	src/journal/JournalPlayer.cc
	src/librbd/Journal.cc
	src/test/rbd_mirror/image_replay.cc
	src/tools/rbd_mirror/ImageReplayer.h
	src/tools/rbd_mirror/Mirror.cc

(merged interface changes to ImageReplayer, and reduced scope for
change to JournalPlayer due to pr #7884 (wip-14663)).

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
@dillaman dillaman deleted the wip-14869 branch March 9, 2016 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants