OSDMonitor: be a little nicer about letting users do pg splitting #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzafman
pushed a commit
that referenced
this pull request
Nov 1, 2013
(manually merged after next branch rebuilt) OSDMonitor: be a little nicer about letting users do pg splitting Reviewed-by: David Zafman <david.zafman@inktank.com>
|
This pull request ended up having to be merged again (e043b6d) because next branch was rebuilt. |
liewegas
pushed a commit
that referenced
this pull request
Dec 14, 2016
Whitelisted 'wrongly marked me down' Reviewed-by: Samuel Just <sjust@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested this by running vstart with two OSDs. Doing split on a pool while a different pool was creating succeeded; trying to split a still-creating pool did not.
gregf@kai:
/ceph/src [next]$ ./ceph osd pool create foo 100 && ./ceph osd pool set data pg_num 50/ceph/src [next]$ ./ceph osd pool set data pg_num 100*** DEVELOPER MODE: setting PATH, PYTHONPATH and LD_LIBRARY_PATH ***
pool 'foo' created
*** DEVELOPER MODE: setting PATH, PYTHONPATH and LD_LIBRARY_PATH ***
set pool 0 pg_num to 50
gregf@kai:
*** DEVELOPER MODE: setting PATH, PYTHONPATH and LD_LIBRARY_PATH ***
Error EAGAIN: currently creating pgs, wait