qa/workunits/rbd: use POSIX function definition #8068
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In scripts with /bin/sh shebang, we must use POSIX function definitions to avoid syntax errors on platforms that link /bin/sh to something other than /bin/bash. See https://wiki.ubuntu.com/DashAsBinSh#function for more information. http://tracker.ceph.com/issues/15104 Fixes: ceph#15104 Signed-off-by: Nathan Cutler <ncutler@suse.com>
jdurgin
added a commit
that referenced
this pull request
Mar 12, 2016
qa/workunits/rbd: use POSIX function definition Reviewed-by: Josh Durgin <jdurgin@redhat.com>
|
Nice explanation in the commit message. Merged to master (jewel will keep getting reset to master next week). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In scripts with /bin/sh shebang, we must use POSIX function definitions to
avoid syntax errors on platforms that link /bin/sh to something other than
/bin/bash.
See https://wiki.ubuntu.com/DashAsBinSh#function for more information.
http://tracker.ceph.com/issues/15104 Fixes: #15104
Signed-off-by: Nathan Cutler ncutler@suse.com