Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

journal overflow fixup #8135

Closed
wants to merge 4 commits into from
Closed

journal overflow fixup #8135

wants to merge 4 commits into from

Conversation

oms4suse
Copy link
Contributor

Fix #14932

Improve ceph-disk error message when there is not enough space to create journal partition.

@smithfarm smithfarm added this to the jewel milestone Mar 15, 2016
@smithfarm smithfarm assigned ghost Mar 15, 2016
@ghost ghost removed this from the jewel milestone Mar 16, 2016
@ghost
Copy link

ghost commented Mar 16, 2016

it looks good to merge after jewel. Could you please add integration tests for Ubuntu 14.04 and CentOS 7 ? They are found in ceph/qa/workunit/ceph-disk and https://github.com/ceph/ceph-qa-suite/tree/master/suites/ceph-disk/basic

@oms4suse
Copy link
Contributor Author

@dachary I am afraid at this moment I don’t know enough about Ceph QA and don’t have the infrastructure to run this on Ubuntu 14.04 and CentOS 7.

If you could point me to some one who can help that would be great.

@smithfarm
Copy link
Contributor

@oms4suse I'd be happy to run suites on Ubuntu 14.04 and CentOS 7.2 for you in our OVH tenant.

@ghost ghost assigned smithfarm and unassigned ghost Mar 17, 2016
@ghost
Copy link

ghost commented Mar 17, 2016

@smithfarm thanks for the help :-) Could you please reassign to me once the tests are passing ?

@oms4suse
ceph_disk.main: s/get_dev_size/get_free_partition_size/
de62428 
The code never needs to know the block device size only the free partion space.

We use parted as the output is consitent across these distributions:

    SUSE Linux Enterprise Server 12 SP1
    openSUSE Leap 42.1 (x86_64)
    Debian GNU/Linux 8.3 (jessie)
    Fedora release 23 (Twenty Three)
    Scientific Linux release 7.2 (Nitrogen)
    Scientific Linux release 6.7 (Carbon)

Signed-off-by: Owen Synge <osynge@suse.com>
@oms4suse
ceph_disk tests/test_prepare: s/get_dev_size/get_free_partition_size/
177d6ef 
Mock get_free_partition_size rather than the now obsolete get_dev_size

Signed-off-by: Owen Synge <osynge@suse.com>
@oms4suse
ceph_disk tests/test_get_free_partition_size: New unit tests
ae6a899 
We need a lot of unit tests as the output of parted is complex.

Signed-off-by: Owen Synge <osynge@suse.com>
@oms4suse
ceph_disk tox.ini: add tests/test_get_free_partition_size.py
789457a 
We need to enable the new unit tests

Signed-off-by: Owen Synge <osynge@suse.com>
@oms4suse
Copy link
Contributor Author

I am currently trying to get the test suite to pass, but really don’t understand the error.

if true && echo w --jobserver-fds=3,4 -j | grep --quiet -e -j && test $u -lt $n ; then
echo "ulimit -u is $u which is lower than $n = $p / 2 * 1024" ;
echo "If running make -j$p check you will likely exceed this limit" ;
echo "and the tests will fail in mysterious ways." ;
echo "Update /etc/security/limits.conf to increase the limit" ;
echo "or run make CHECK_ULIMIT=false -j4 check to override this safeguard." ;
exit 1 ;
fi
FAIL: src/test/run-cli-tests
make[4]: Entering directory `/h

I am now trying to get "src/test/run-cli-tests" to succeed on a local build.

@oms4suse
Copy link
Contributor Author

OK I have made "src/test/run-cli-tests" pass on master and am now rebuilding on my branch.

@oms4suse
Copy link
Contributor Author

I have made "src/test/run-cli-tests" pass on my branch.

Maybe I am missing some thing and this test is failing because of some environment issue.

Please can I have help as to wear to look.

@smithfarm
Copy link
Contributor

it looks good to merge after jewel. Could you please add integration tests for Ubuntu 14.04 and CentOS 7 ? They are found in ceph/qa/workunit/ceph-disk and https://github.com/ceph/ceph-qa-suite/tree/master/suites/ceph-disk/basic

I am going to be doing some ceph-disk work soon, which will include adding tests to the ceph-disk suite. I'll add these tests, too.

smithfarm added a commit to SUSE/ceph that referenced this pull request Nov 4, 2016
@smithfarm
Revert "ceph_disk.main: s/get_dev_size/get_free_partition_size/"
2d8d8e3 
This reverts commit 8111d9e.

Revert a non-critical downstream-only commit to avoid conflicts when merging
the upstream "jewel" branch into our downstream ses3 and ses4 branches.

Upstream PR ceph#8135 is pending.

Signed-off-by: Nathan Cutler <ncutler@suse.com>
@liewegas
Copy link
Member

@oms4suse ping

@jan--f jan--f deleted the wip-journal-overflow branch February 8, 2017 20:31
@liewegas
Copy link
Member

closing this. feel free to reopen and rebase if it's still a problem!

@liewegas liewegas closed this Mar 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@smithfarm smithfarm

Labels
bug-fix tools
Projects
None yet
Milestone
No milestone
3 participants
@oms4suse @smithfarm @liewegas