rpm: prefer UID/GID 167 when creating ceph user/group #8277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change affects openSUSE/SLE only. http://tracker.ceph.com/issues/15246 Fixes: ceph#15246 Signed-off-by: Nathan Cutler <ncutler@suse.com>
| %if 0%{?rhel} || 0%{?fedora} | ||
| %{_sbindir}/groupadd ceph $CEPH_GROUP_ID -o -r 2>/dev/null || : | ||
| %{_sbindir}/useradd ceph $CEPH_USER_ID -o -r -g ceph -s /sbin/nologin -c "Ceph daemons" -d %{_localstatedir}/lib/ceph 2> /dev/null || : | ||
| %{_sbindir}/groupadd ceph -g $CEPH_GROUP_ID -o -r 2>/dev/null || : |
There was a problem hiding this comment.
Are the "|| :" suffixes here and below necessary? The script unconditionally finishes with exit 0.
There was a problem hiding this comment.
Yep, they are necessary. you could have created your own ceph group/user before you installed ceph packages and the groupadd code would then cause the %pre script to fail.
Another alternative: you installed the packages that created the group and then removed and installed them again -- you would hit the same issue. The same will probably apply to upgrades, etc...
Also, afaik, rpm scripts finish on first line that fails.
|
@BRANTO1 mind taking a quick look? |
|
@liewegas: this change lgtm. |
liewegas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change affects openSUSE/SLE only.
http://tracker.ceph.com/issues/15246 Fixes: #15246
Signed-off-by: Nathan Cutler ncutler@suse.com